impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs
Date Tue, 17 Oct 2017 23:09:08 GMT
Michael Brown has posted comments on this change. ( )

Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

Patch Set 1:

Commit Message:
PS1, Line 9: JENKINS-1102 added the IAM role ImpalaDev to the Impala Jenkins workers
           : to facilitate s3 access without having to carry around AWS credentials
           : in environment variables, from where they were prone to escape to log
           : files posted in public places.
This looks like something specific to a downstream environment and should be removed from
the commit message.
File bin/
PS1, Line 268: test
PS1, Line 276: curl -sf --connect-timeout 1 --max-time 5
Are these curl options common across a wide variety of OSs? If they are newer and only work
under, say, Ubuntu 16, they would be a problem for contributors using older distributions.
PS1, Line 276:
Is there a AWS reference page you can add as a comment so I can read up more on this?
File testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.tmpl:
PS1, Line 61: <!-- BEGIN s3 security settings -->
Maybe have a comment explaining testdata/cluster/admin needs this (and the END) as a marker
and not to remove?

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14cd9d4453a91baad3c379aa7e4944993fca95ae
Gerrit-Change-Number: 8294
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Laszlo Gaal <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Comment-Date: Tue, 17 Oct 2017 23:09:08 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message