impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem
Date Sat, 14 Oct 2017 01:02:08 GMT
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8272
)

Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem
......................................................................

IMPALA-6049: breakpad tests: skip all tests with local filesystem

The breakpad tests were recently refactored to support inclusion of one
of them as a core test. In this refactor, we neglected to ensure
setup_class() called its parent. This means the skipping called in said
parent doesn't occur, and the test is executed in an unsupported
environment (local filesystem).

This patch fixes that by ensuring we call the parent setup_class() via
super().

Testing:

$ TARGET_FILESYSTEM="local" impala-py.test tests/custom_cluster/test_breakpad.py \
      -k test_abort_writes_minidump

tests/custom_cluster/test_breakpad.py::TestBreakpadCore::test_abort_writes_minidump
SKIPPED

Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Reviewed-on: http://gerrit.cloudera.org:8080/8272
Reviewed-by: Sailesh Mukil <sailesh@cloudera.com>
Reviewed-by: Lars Volker <lv@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Sailesh Mukil: Looks good to me, but someone else must approve
  Lars Volker: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Gerrit-Change-Number: 8272
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message