impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner
Date Thu, 12 Oct 2017 00:33:05 GMT
Lars Volker has posted comments on this change. ( )

Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

Patch Set 2:

File be/src/exec/parquet-column-stats.inline.h:
PS2, Line 89:   switch(parquet_type){
> Do you mean to have a Decode wrapper around the templatized Decode methods?
The former, so that the interface of Decode() is simpler. How this is implemented seems more
a concern of the decoder than the column stats.
File be/src/exec/parquet-common.h:
PS2, Line 237: ByteSize
> Do you mean to have something like 
I think this particular call here will always return sizeof(int32_t) (line 220). I'd just
put that here, since your change explicitly documents that as a template parameter.
PS2, Line 338: template <>
> thats kinda difficult because DecimalUtil::DecodeFromFixedLenByteArray is a
I'm not sure I'm following: it looks like the next three methods are exactly the same. Couldn't
you move them into a new method DecodeDecimalValue<T>(const uint8_t* buffer, const uint8_t*
buffer_end, int fixed_len_size, T* v) and then call it and return in one line here? I may
be missing something though :)

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c0e881045109f337fecba53fec21f9cfb9e619e
Gerrit-Change-Number: 7822
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <>
Gerrit-Reviewer: Bikramjeet Vig <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Thu, 12 Oct 2017 00:33:05 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message