impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork
Date Wed, 11 Oct 2017 05:33:37 GMT
Sailesh Mukil has posted comments on this change. ( )

Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

Patch Set 6:

File be/src/exec/kudu-util.h:
PS6, Line 45: (FromKuduStatus(status))
> nit: parenthesis not needed.
File be/src/rpc/auth-provider.h:
PS6, Line 144: forks
> nit: forks Impalad and exec 'kinit'
File be/src/rpc/
PS6, Line 77:     "Only used when FLAGS_use_krpc is false");
> Okay. So in other words, we could have fixed the old code as well, and elim
Yes, we could have, but we couldn't deprecate this flag in a minor release anyway, so I never
went ahead with it.
File be/src/rpc/
PS6, Line 117: !(GetParam() == USE_KUDU_KERBEROS)
> Did you flip the polarity ?
Oops, I did that for some local testing verification and forgot to turn it back. Switched
it back.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7
Gerrit-Change-Number: 7938
Gerrit-PatchSet: 6
Gerrit-Owner: Sailesh Mukil <>
Gerrit-Reviewer: Bikramjeet Vig <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Comment-Date: Wed, 11 Oct 2017 05:33:37 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message