impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables. (wip)
Date Tue, 10 Oct 2017 19:30:47 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 )

Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. (wip)
......................................................................


Patch Set 1:

This seems pretty beneficial - a 1-2s speedup is pretty significant for short running queries
(which should be common for Avro since it's generally only recommended for smaller data sets).
It feels like there's a bit of redundancy with the duplicated code to create functions with
the same signatures but it's not immediately clear if there's a good abstraction to avoid
it.


-- 
To view, visit http://gerrit.cloudera.org:8080/8211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f1b390be4adf6e6699a18344234f8ff7ee74476
Gerrit-Change-Number: 8211
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Oct 2017 19:30:47 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message