impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test
Date Tue, 10 Oct 2017 17:24:46 GMT
Hello Michael Brown, Sailesh Mukil, 

I'd like you to reexamine a change. Please visit

to look at the new patch set (#4).

Change subject: IMPALA-6023: Fix broken breakpad test

IMPALA-6023: Fix broken breakpad test

We have a test to make sure that hitting a DCHECK will write a minidump.
We used to pass "-beeswax_port=1" to the server to trigger a DCHECK. A
while ago, this DCHECK seems to have been removed, but we still called
abort() if the ImpalaServer failed to start. This masked the slightly
altered behavior and the test still succeeded.

However, the fix for IMPALA-4786 changed the behavior to call exit(1)
instead of abort() if the ImpalaServer failed to start.

To fix the test, we change it to pass an unresolvable hostname to
impalad, which will result in a call to abort().

This change also splits the breakpad tests into core and exhaustive sets
to make sure that tests which depend on other parts of Impala are
included in every core run.

Change-Id: Ifb5af3e72963280a6677a99aa6a0e5785443bb0c
M tests/custom_cluster/
1 file changed, 33 insertions(+), 23 deletions(-)

  git pull ssh:// refs/changes/40/8240/4
To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb5af3e72963280a6677a99aa6a0e5785443bb0c
Gerrit-Change-Number: 8240
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Sailesh Mukil <>

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message