impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test
Date Tue, 10 Oct 2017 15:50:42 GMT
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8240 )

Change subject: IMPALA-6023: Fix broken breakpad test
......................................................................


Patch Set 3:

(3 comments)

Thanks for looking into this.

http://gerrit.cloudera.org:8080/#/c/8240/3/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

http://gerrit.cloudera.org:8080/#/c/8240/3/tests/custom_cluster/test_breakpad.py@149
PS3, Line 149: @SkipIfBuildType.not_dev_build
This was here due to needing DCHECK behavior before, right? What about abort() on release
builds? Can this be removed?


http://gerrit.cloudera.org:8080/#/c/8240/3/tests/custom_cluster/test_breakpad.py@174
PS3, Line 174: super(TestBreakpadExhaustive).setup_class();
Change to:

  super(TestBreakpadExhaustive, cls).setup_class()

1. Drop the semi-colon
2. Pass in the cls argument to super()

Although what you wrote is syntactically valid, it's semantically invalid in this context
and fails at runtime. More here: https://docs.python.org/2.7/library/functions.html#super

Btw, I found this doing an accounting of your tests to be run in both core and exhaustive:

  impala-py.test --workload_exploration_strategy functional-query:exhaustive tests/custom_cluster/test_breakpad.py


http://gerrit.cloudera.org:8080/#/c/8240/3/tests/custom_cluster/test_breakpad.py@333
PS3, Line 333: 
Some blank lines at the end of the file.



-- 
To view, visit http://gerrit.cloudera.org:8080/8240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5af3e72963280a6677a99aa6a0e5785443bb0c
Gerrit-Change-Number: 8240
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Oct 2017 15:50:42 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message