impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork
Date Mon, 09 Oct 2017 19:10:05 GMT
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 )

Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7938/5/be/src/kudu/security/init.cc
File be/src/kudu/security/init.cc:

http://gerrit.cloudera.org:8080/#/c/7938/5/be/src/kudu/security/init.cc@460
PS5, Line 460:   //setenv("KRB5CCNAME", "MEMORY:kudu", 1);
             :   //setenv("KRB5_KTNAME", FLAGS_keytab_file.c_str(), 1);
             :   // We commented out the above since we don't want to overwrite our own Impala
             :   // set environment variables.
> Is this function used for testing only ? If so, would it be better to move 
No, this function is what initializes Kerberos in the kudu security library. See L843 in authentication.cc

Unfortunately, there isn't a clean way to make this configurable, unless we pass in strings
to the InitKerberosForServer() function as parameters for these environment variables, which
makes little sense for Kudu to have in their code base.


http://gerrit.cloudera.org:8080/#/c/7938/5/be/src/kudu/security/init.cc@469
PS5, Line 469:   //setenv("KRB5RCACHETYPE", "none", 1);
> Same comment.
Same as above.



-- 
To view, visit http://gerrit.cloudera.org:8080/7938
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7
Gerrit-Change-Number: 7938
Gerrit-PatchSet: 5
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Oct 2017 19:10:05 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message