impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
Date Fri, 06 Oct 2017 05:21:29 GMT
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/7999 )

Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7999/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/7999/1/docs/shared/impala_common.xml@1226
PS1, Line 1226:         and the statistics are computed again from the beginning. Therefore,
expect a one-time
> from scratch
Done


http://gerrit.cloudera.org:8080/#/c/7999/1/docs/shared/impala_common.xml@1241
PS1, Line 1241: -- by -1 under #Rows and false under Incremental stats.
> I suggest you leave out the -1 under #Rows part since that may be confusing
Done. The extra details could make good additions to the 'DROP STATS' and 'background on incremental
stats' topics, but let's save that for a followup gerrit.


http://gerrit.cloudera.org:8080/#/c/7999/1/docs/topics/impala_partitioning.xml
File docs/topics/impala_partitioning.xml:

http://gerrit.cloudera.org:8080/#/c/7999/1/docs/topics/impala_partitioning.xml@611
PS1, Line 611:         Because the <codeph>COMPUTE STATS</codeph> statement can
be resource-intensive to run frequently
> This advice isn't prescriptive enough for my taste. We should state very cl
OK, why don't I fold that into the 'incremental_stats_after_full' note below, and rearrange
the text so that note comes earlier. Support is always asking for advice to be in "big red
boxes" and the <note> idiom is the most eye-catching way we have to do that. (The original
text in the note box is reused on 3 pages: "Partitioning", "Performance - Statistics", and
"COMPUTE STATS". I'll include the expanded version of the note in all 3 places.)


http://gerrit.cloudera.org:8080/#/c/7999/1/docs/topics/impala_partitioning.xml@613
PS1, Line 613:         that is optimized for processing partitioned tables.
> I wouldn't say that incremental stats is "optimized" for partitioned tables
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/7999
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03
Gerrit-Change-Number: 7999
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Silvius Rus <srus@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2017 05:21:29 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message