impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <>
Subject [Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
Date Fri, 06 Oct 2017 05:21:29 GMT
John Russell has posted comments on this change. ( )

Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS

Patch Set 1:

File docs/shared/impala_common.xml:
PS1, Line 1226:         and the statistics are computed again from the beginning. Therefore,
expect a one-time
> from scratch
PS1, Line 1241: -- by -1 under #Rows and false under Incremental stats.
> I suggest you leave out the -1 under #Rows part since that may be confusing
Done. The extra details could make good additions to the 'DROP STATS' and 'background on incremental
stats' topics, but let's save that for a followup gerrit.
File docs/topics/impala_partitioning.xml:
PS1, Line 611:         Because the <codeph>COMPUTE STATS</codeph> statement can
be resource-intensive to run frequently
> This advice isn't prescriptive enough for my taste. We should state very cl
OK, why don't I fold that into the 'incremental_stats_after_full' note below, and rearrange
the text so that note comes earlier. Support is always asking for advice to be in "big red
boxes" and the <note> idiom is the most eye-catching way we have to do that. (The original
text in the note box is reused on 3 pages: "Partitioning", "Performance - Statistics", and
"COMPUTE STATS". I'll include the expanded version of the note in all 3 places.)
PS1, Line 613:         that is optimized for processing partitioned tables.
> I wouldn't say that incremental stats is "optimized" for partitioned tables

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03
Gerrit-Change-Number: 7999
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Greg Rahn <>
Gerrit-Reviewer: John Russell <>
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Silvius Rus <>
Gerrit-Comment-Date: Fri, 06 Oct 2017 05:21:29 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message