impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
Date Thu, 05 Oct 2017 18:36:06 GMT
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 )

Change subject: IMPALA-5529: [DOCS] New trunc() signatures
......................................................................


Patch Set 4:

(1 comment)

I pulled the numeric aspect of trunc() out of Date/Time Functions and added it into the existing
trunc() / dtrunc() entry under Arithmetic Functions. Because we have so many cases of multiple
names/aliases for the same function, our practice is to cover them all together rather than
make individual entries for each.

http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml@2174
PS3, Line 2174: dt>
              : 
> Why don't we add a pointer from dtrunc / truncate to here. Those are covere
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826
Gerrit-Change-Number: 8189
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 18:36:06 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message