impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6011: Remove use of Guava Hasher.
Date Thu, 05 Oct 2017 17:47:36 GMT
Tim Armstrong has posted comments on this change. ( )

Change subject: IMPALA-6011: Remove use of Guava Hasher.

Patch Set 1:

Commit Message:
PS1, Line 15:   in the shell. I verified that the new code is executed.
> lineage.test is a planner test. It succeeds because we don't compare the qu
So we don't have any testing that the query hash is a sensible value? I don't think you broke
it but seems like a test coverage gap.
File fe/src/main/java/org/apache/impala/analysis/
PS1, Line 601:     // String conversion code taken from Guava's HashCode.toString().
> I bet we are pulling in many versions of Apache commons as well. The API ma
I'm still wondering if this should be a separate utility function.

It seems ok to have our own version of this but in general that argument about dependencies
would justify never using external libraries, which doesn't seem right.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b8888b436eb93a86b8db24b2a97f14047f828b
Gerrit-Change-Number: 8216
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Thu, 05 Oct 2017 17:47:36 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message