impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6011: Remove use of Guava Hasher.
Date Thu, 05 Oct 2017 15:11:30 GMT
Tim Armstrong has posted comments on this change. ( )

Change subject: IMPALA-6011: Remove use of Guava Hasher.

Patch Set 1:

Commit Message:
PS1, Line 15:   in the shell. I verified that the new code is executed.
It looks like lineage.test verifies the exact value of some query hashes too (wanted to convince
myself that that didn't accidentally change).
File fe/src/main/java/org/apache/impala/analysis/
PS1, Line 596:       return "Query hash failed";
Seems like this should be a precondition or throw a runtime error or similar (it looked like
Guava throws an AssertionError).
PS1, Line 601:     // String conversion code taken from Guava's HashCode.toString().
Seems like the string conversion code should be a utility function. Alternatively it looks
like commons-codec has  a function that does this:[])

I guess part of the point was to reduce our dependency on external libraries, but I think
Apache commons generally has more stable APIs.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b8888b436eb93a86b8db24b2a97f14047f828b
Gerrit-Change-Number: 8216
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Thu, 05 Oct 2017 15:11:30 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message