impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication
Date Wed, 04 Oct 2017 03:05:38 GMT
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 )

Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7438/11/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/7438/11/be/src/exprs/expr-test.cc@1544
PS11, Line 1544:         DCHECK(false) << "Unexpected character.";
This is causing a clang-tidy error in your last GVD:

See the last lines of https://jenkins.impala.io/job/gerrit-verify-dryrun/1292/console

    ERROR: There were some failed jobs: [https://jenkins.impala.io/job/clang-tidy/1606/, https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/374/]

Then the last lines of the URL it points to, https://jenkins.impala.io/job/clang-tidy/1606/console:

    /home/ubuntu/Impala/be/src/exprs/expr-test.cc:1543:7: warning: variable 'digit' is used
uninitialized whenever switch default is taken [clang-diagnostic-sometimes-uninitialized]



-- 
To view, visit http://gerrit.cloudera.org:8080/7438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37ad6232d7953bd75c18dc86e665b2b501a1ebe1
Gerrit-Change-Number: 7438
Gerrit-PatchSet: 11
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Oct 2017 03:05:38 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message