impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5844: use a MemPool for expr result allocations
Date Tue, 03 Oct 2017 20:26:10 GMT
Dan Hecht has posted comments on this change. ( )

Change subject: IMPALA-5844: use a MemPool for expr result allocations

Patch Set 11:


This is looking very good. Todo for me:
File be/src/exec/exec-node.h:
PS11, Line 379:   Status QueryMaintenance(RuntimeState* state) WARN_UNUSED_RESULT;
I still think we should get rid of this but okay to leave in this change.
File be/src/exec/hash-table.h:
PS11, Line 396: Cloes
PS11, Line 525:   /// results of expr evaluation.
Not owned? Which also means the exec node will do the maintenance on them, right?
File be/src/exec/partitioned-aggregation-node.h:
PS11, Line 214: if this is a non-grouping aggregation used
              :   /// for the non-grouping cases
did that get garbled?
PS11, Line 219:   /// are allocated from 'expr_perm_pool_' and 'expr_results_pool_' respectively.
and what about for grouping case?
PS11, Line 419: expr_managed
should this be talking about permanent?
PS11, Line 420: per partition
I don't get that comment, given this is a single pool.
PS11, Line 421: Local allocations
File be/src/exec/scanner-context.h:
PS11, Line 337:   /// evaluation to prevent memory from accumulating.
who owns this?
and why does this make sense in ScannerContext? (reading the class comment it's not clear
why a lot of this stuff is here).
File be/src/udf/udf.h:
PS11, Line 350: For allocations that back the intermediate results of aggregation
              : /// returned by Init(), Update() and Merge() should be allocated by
a bit garbled
PS11, Line 616: temporary
this is kind of new terminology. above i think you said "temporary results". maybe that, or
just "results"?
File be/src/util/tuple-row-compare.h:
PS11, Line 77: Any
             :   /// the evaluators with use

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ba5a7542ed90a49a4b5586c040b5985a7d45b61
Gerrit-Change-Number: 8025
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Tue, 03 Oct 2017 20:26:10 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message