impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.
Date Tue, 03 Oct 2017 18:29:16 GMT
Michael Ho has posted comments on this change. ( )

Change subject: IMPALA-5940: Avoid log spew by using Status::Expected.

Patch Set 3:

File be/src/runtime/client-cache.h:
PS3, Line 246:         return Status::Expected(ErrorMsg(TErrorCode::RPC_RECV_TIMEOUT, err));
> Yea, the backtrace is not all that useful here. Forgot to add that. I was a
I agree that removing the backtrace here is the right direction as 90% of the cases logged
are from DataStreamSender and they are considered "harmless" in this case.

The caller of this function from DataStreamSender is from  DataStreamSender::Channel::DoTransmitDataRpc()
which will react to a timeout error by retrying the recv part of the RPC repeatedly until
success or a non-timeout related error is found. So, in that sense, the RECV_TIMEOUT error
shouldn't be logged in GetSendStatus() until it hits other errors.

I did a quick audit of all callers of DoRpc() and it appears that some callers didn't really
log the error. So, it may still be a bit inconvenient in those cases but this can be made
up by adding more logging in those cases instead. (e.g. CatalogOpExecutor::Exec)
PS3, Line 281:         return Status::Expected(ErrorMsg(TErrorCode::RPC_RECV_TIMEOUT, err));
> same set of comment/question
This one is definitely fine to not log the backtrace as we know this is coming from DataStreamSender
for sure.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38088482377a1c3e794a9c8178ef83f29957a330
Gerrit-Change-Number: 8100
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Comment-Date: Tue, 03 Oct 2017 18:29:16 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message