impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication
Date Tue, 03 Oct 2017 17:11:57 GMT
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 )

Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication
......................................................................


Patch Set 8: Code-Review+2

(3 comments)

Changes seem okay to me, but might be good to have Tim also take a look.

http://gerrit.cloudera.org:8080/#/c/7438/8/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/7438/8/be/src/exprs/expr-test.cc@1672
PS8, Line 1672: not require int256.
if result does not require int256, why does it overflow (return null)?


http://gerrit.cloudera.org:8080/#/c/7438/8/be/src/exprs/expr-test.cc@1675
PS8, Line 1675: { true, 0, 38, 0 }}},
when both V1 and V2 give the same answer, you don't have to include both results


http://gerrit.cloudera.org:8080/#/c/7438/8/be/src/exprs/expr-test.cc@1702
PS8, Line 1702: 85070591730234615865843651857942052864
how did you verify these results?



-- 
To view, visit http://gerrit.cloudera.org:8080/7438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37ad6232d7953bd75c18dc86e665b2b501a1ebe1
Gerrit-Change-Number: 7438
Gerrit-PatchSet: 8
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 17:11:57 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message