impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
Date Tue, 03 Oct 2017 14:39:36 GMT
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 )

Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
......................................................................


Patch Set 10:

(1 comment)

Thanks for giving gerrit-verify-dryrun-external a try! It caught something (see inline comment).

Looks like this patch now can't merge due to conflicts in impala-server.cc, likely due to
the very recent https://gerrit.cloudera.org/#/c/8076/.

http://gerrit.cloudera.org:8080/#/c/7061/10/be/src/rpc/TAcceptQueueServer.h
File be/src/rpc/TAcceptQueueServer.h:

http://gerrit.cloudera.org:8080/#/c/7061/10/be/src/rpc/TAcceptQueueServer.h@135
PS10, Line 135: int32_t maxTasks = 0
Here and elsewhere, clang-tidy and clang compilations are unhappy with the following:

  be/src/rpc/TAcceptQueueServer.h:135:13: error: default arguments cannot be added to a function
template that has already been declared
      int32_t maxTasks = 0,
              ^          ~
  be/src/rpc/TAcceptQueueServer.h:58:3: note: previous template declaration is here
    TAcceptQueueServer(const boost::shared_ptr<ProcessorFactory>& processorFactory,

https://jenkins.impala.io/job/clang-tidy/1601/
https://jenkins.impala.io/job/all-build-options/1600/



-- 
To view, visit http://gerrit.cloudera.org:8080/7061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
Gerrit-Change-Number: 7061
Gerrit-PatchSet: 10
Gerrit-Owner: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Matthew Jacobs <mjacobs@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 14:39:36 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message