Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 58AB8200D09 for ; Tue, 12 Sep 2017 18:13:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 575A41609C7; Tue, 12 Sep 2017 16:13:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9BFB71609C6 for ; Tue, 12 Sep 2017 18:13:55 +0200 (CEST) Received: (qmail 57498 invoked by uid 500); 12 Sep 2017 16:13:54 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 57486 invoked by uid 99); 12 Sep 2017 16:13:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Sep 2017 16:13:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DAFFB18CA3E for ; Tue, 12 Sep 2017 16:13:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id mFUf2wSrJNkr for ; Tue, 12 Sep 2017 16:13:52 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A28BD5F640 for ; Tue, 12 Sep 2017 16:13:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8CGDnXv017032; Tue, 12 Sep 2017 16:13:49 GMT Date: Tue, 12 Sep 2017 16:13:49 +0000 From: "Alex Behm (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5856=3A_Fix_outer_join_predicate_assignment=2E=0A?= X-Gerrit-Change-Id: I93db34d988cb66e00aa05d7dc161e0ca47042acb X-Gerrit-ChangeURL: X-Gerrit-Commit: 15958990557ac82c596df0d8c4ff6d68c68a516e MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 12 Sep 2017 16:13:56 -0000 Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/8039 Change subject: IMPALA-5856: Fix outer join predicate assignment. ...................................................................... IMPALA-5856: Fix outer join predicate assignment. Fixes incorrect assignment of join predicates with the following properties: - from the On-clause of a left outer join - only references the left-hand side tuples (not the right hand side tuple) - references full-outer joined tuples; the full outer join appears on the left Testing: - a core/hdfs run passed - added new regression test Change-Id: I93db34d988cb66e00aa05d7dc161e0ca47042acb --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M testdata/workloads/functional-planner/queries/PlannerTest/outer-joins.test 2 files changed, 43 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/8039/1 -- To view, visit http://gerrit.cloudera.org:8080/8039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I93db34d988cb66e00aa05d7dc161e0ca47042acb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm