Return-Path: <reviews-return-20662-archive-asf-public=cust-asf.ponee.io@impala.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 9BE0A200D02
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Sat,  9 Sep 2017 00:13:40 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 9A2A91609ED; Fri,  8 Sep 2017 22:13:40 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id E0EAE1609EA
	for <archive-asf-public@cust-asf.ponee.io>; Sat,  9 Sep 2017 00:13:39 +0200 (CEST)
Received: (qmail 95085 invoked by uid 500); 8 Sep 2017 22:13:37 -0000
Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@impala.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@impala.incubator.apache.org>
List-Post: <mailto:reviews@impala.incubator.apache.org>
List-Id: <reviews.impala.incubator.apache.org>
Delivered-To: mailing list reviews@impala.incubator.apache.org
Received: (qmail 95074 invoked by uid 99); 8 Sep 2017 22:13:37 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Sep 2017 22:13:37 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2FEB51917AD
	for <reviews@impala.apache.org>; Fri,  8 Sep 2017 22:13:37 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.362
X-Spam-Level: 
X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31
	tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024)
	with ESMTP id UR72g_N30bfl for <reviews@impala.apache.org>;
	Fri,  8 Sep 2017 22:13:36 +0000 (UTC)
Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BB28C60DA9
	for <reviews@impala.incubator.apache.org>; Fri,  8 Sep 2017 22:13:35 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v88MDYjY032667;
	Fri, 8 Sep 2017 22:13:34 GMT
Date: Fri, 8 Sep 2017 22:13:34 +0000
From: "Vuk Ercegovac (Code Review)" <gerrit@cloudera.org>
To: Marcel Kornacker <marcelk@gmail.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Message-ID: <gerrit.1504908814000.I5bd0aa82a0316ac236b7ecf8612ef4b30c016a00@gerrit.cloudera.org>
Reply-To: vercegovac@cloudera.com
X-Gerrit-MessageType: newchange
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1767_Adds_predicate_to_test_boolean_values_true=2C_false=2C_unknown=2E=0A?=
X-Gerrit-Change-Id: I5bd0aa82a0316ac236b7ecf8612ef4b30c016a00
X-Gerrit-ChangeURL: <http://gerrit.cloudera.org:8080/8014>
X-Gerrit-Commit: f2fb46a22e6aa9eac53a93cf0bb9338df8dc2e21
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Fri, 08 Sep 2017 22:13:40 -0000

Vuk Ercegovac has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/8014

Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown.
......................................................................

IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

Adds a new expression to represent the following boolean predicate:
<expr> IS [NOT] (TRUE | FALSE | UNKNOWN)
The expression is rewritten into compound expressions using
negation, is null, and equality. As a result, there are no BE
operators to eval this predicate.

Testing:
- Frontend: parser, analyzer, rewriter, tosql
- EndToEnd query expressions

Change-Id: I5bd0aa82a0316ac236b7ecf8612ef4b30c016a00
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/BoolTestPredicate.java
A fe/src/main/java/org/apache/impala/rewrite/BoolTestToCompoundRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
10 files changed, 318 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/8014/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bd0aa82a0316ac236b7ecf8612ef4b30c016a00
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <vercegovac@cloudera.com>