Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 6 Sep 2017 01:04:33 +0000
From: "Bikramjeet Vig (Code Review)" <gerrit@cloudera.org>
To: Marcel Kornacker <marcelk@gmail.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Message-ID: <gerrit.1504659847000.I6e425dbcb442aeeac687e103774823d3f50e6436@gerrit.cloudera.org>
Reply-To: bikramjeet.vig@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5812=3A_NPE_when_x_joining_on_const_select_having_an_empty_result=0A?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Wed, 06 Sep 2017 01:04:37 -0000

Bikramjeet Vig has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7971

Change subject: IMPALA-5812: NPE when x joining on const select having an empty result
......................................................................

IMPALA-5812: NPE when x joining on const select having an empty result

A NPE is thrown during the creation of the single node plan of a query
consisting of a cross join with a constant select that returns
an empty result set. This happens because when an empty-set plan node
is created, its tupleIds_ and tblRefIds_ are initialized with the
tuple ID of a newly create tuple that does not map to any existing
tableRefs. This causes a null pre-check to fail during the creation
of the join node when it tries to fetch the tableRef from that new
tuple Id in the empty-set node but doesn't find one.

Testing:
Added a planner test.

Change-Id: I6e425dbcb442aeeac687e103774823d3f50e6436
---
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
2 files changed, 19 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/7971/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e425dbcb442aeeac687e103774823d3f50e6436
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>