Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 59B18200D1D for ; Sat, 30 Sep 2017 00:56:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4C93A1609ED; Fri, 29 Sep 2017 22:56:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 939751609D1 for ; Sat, 30 Sep 2017 00:56:53 +0200 (CEST) Received: (qmail 68304 invoked by uid 500); 29 Sep 2017 22:56:52 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 68291 invoked by uid 99); 29 Sep 2017 22:56:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 22:56:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1F4F11A1C76 for ; Fri, 29 Sep 2017 22:56:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.612 X-Spam-Level: ** X-Spam-Status: No, score=2.612 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LOTSOFHASH=0.25, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ufvY24RONYUZ for ; Fri, 29 Sep 2017 22:56:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 785505F3CE for ; Fri, 29 Sep 2017 22:56:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8TMum6g021716; Fri, 29 Sep 2017 22:56:49 GMT Message-Id: <201709292256.v8TMum6g021716@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Fri, 29 Sep 2017 22:56:48 +0000 From: "Philip Zeyliger (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Re-apply=3A_IMPALA-5589=3A_change_=22set=22_in_impala-shell_to_show_empty_string_for_unset_query_options=0A?= X-Gerrit-Change-Id: I29f5d8ab874cb1338077f16019a9537766cac0c4 X-Gerrit-Change-Number: 8096 X-Gerrit-ChangeURL: X-Gerrit-Commit: 598b72cf43a326dd3c8a9a35994f8007db665b93 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 29 Sep 2017 22:56:48 +0000 Reply-To: philip@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org, dhecht@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="4UZyhAxh4fQ="; charset=UTF-8 archived-at: Fri, 29 Sep 2017 22:56:54 -0000 --4UZyhAxh4fQ= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Philip Zeyliger has posted comments on this change=2E ( http://gerrit=2Eclo= udera=2Eorg:8080/8096 ) Change subject: Re-apply: IMPALA-5589: change "set= " in impala-shell to show empty string for unset query options =2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Patch Set 3: > Patch Se= t 3: > > Is this the same patch as before (I=2Ee=2E can we just carry forw= ard that +2), or did something in this diff change since the +2? This is a= computer-generated revert-of-a-revert with a slight change to the commit m= essage=2E I double checked with git patch-id; they're the same diff=2E = $git log --oneline --grep IMPALA-5589 | grep -v Revert 598b72c Re-apply: IM= PALA-5589: change "set" in impala-shell to show empty string for unset quer= y options 387bde0 IMPALA-5589: change "set" in impala-shell to show empty s= tring for unset query options $git show 387bde0 | git-patch-id --stable; g= it show 598b72c | git-patch-id --stable 47b02290d8b30ffa520ea19dac8353075c5= a5bc7 387bde0639ffd8ef580ccbf727152954e62bacbe 47b02290d8b30ffa520ea19dac83= 53075c5a5bc7 598b72cf43a326dd3c8a9a35994f8007db665b93 -- To view, visit = http://gerrit=2Ecloudera=2Eorg:8080/8096 To unsubscribe, visit http://gerri= t=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch:= master Gerrit-MessageType: comment Gerrit-Change-Id: I29f5d8ab874cb1338077= f16019a9537766cac0c4 Gerrit-Change-Number: 8096 Gerrit-PatchSet: 3 Gerrit-O= wner: Philip Zeyliger Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 29 Sep 2017 22:56:48 +0000 Gerrit-HasComments= : No --4UZyhAxh4fQ=--