Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A85F0200D1D for ; Sat, 30 Sep 2017 00:37:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A54E21609ED; Fri, 29 Sep 2017 22:37:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9D0031609D1 for ; Sat, 30 Sep 2017 00:37:15 +0200 (CEST) Received: (qmail 33913 invoked by uid 500); 29 Sep 2017 22:37:14 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 33902 invoked by uid 99); 29 Sep 2017 22:37:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 22:37:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2530E180CF3 for ; Fri, 29 Sep 2017 22:37:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.562 X-Spam-Level: ** X-Spam-Status: No, score=2.562 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_MANYTO=0.2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id A5A2hzJ2WXVm for ; Fri, 29 Sep 2017 22:37:10 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BEA1060D08 for ; Fri, 29 Sep 2017 22:37:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8TMb7N8020897; Fri, 29 Sep 2017 22:37:07 GMT Message-Id: <201709292237.v8TMb7N8020897@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 12 Date: Fri, 29 Sep 2017 22:37:07 +0000 From: "Tim Wood (Code Review)" To: Matthew Mulder , Michael Brown , David Knupp , Alex Behm , Mostafa Mokhtar , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5376=3A_Implement_all_TPCDS_test_cases_or_alternates_for_Impala=2E=0A?= X-Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 X-Gerrit-Change-Number: 8102 X-Gerrit-ChangeURL: X-Gerrit-Commit: c935f8966dfa4c4cb7fe6f92e9134973e3861bd3 In-Reply-To: References: Reply-To: twood@cloudera.com, mmulder@cloudera.com, impala-cr@cloudera.com, dknupp@cloudera.com, marcelk@gmail.com, mmokhtar@cloudera.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org, mikeb@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="45Va7V6KlXE="; charset=UTF-8 archived-at: Fri, 29 Sep 2017 22:37:16 -0000 --45Va7V6KlXE= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Matthew Mulder, Michael Brown, David Knupp, Alex Behm, Mostafa Mokhta= r, Michael Ho, I'd like you to reexamine a change=2E Please visit ht= tp://gerrit=2Ecloudera=2Eorg:8080/8102 to look at the new patch set (#12)= =2E Change subject: IMPALA-5376: Implement all TPCDS test cases or alterna= tes for Impala=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E IMPALA-5376: Implement all TPCDS test cases or alternates for Impala= =2E Main source for TPCDS query and result definitions: https://github=2Ec= om/gregrahn/tpcds-kit=2E TPC-DS v2=2E5=2E0 qualification queries from G=2E = Rahn, Cloudera, Inc=2E Data set constructed in mini-cluster using $IMPALA_H= OME/buildall=2Esh -testdata=2E=2E=2E=2E This commit continues previous work= on IMPALA-5376 in the ASF Impala repo and the Cloudera Gerrit service=2E = This commit splits multi-query tests in the TPC-DS suite definition into on= e query and result set per test file, as the test framework requires=2E Na= mes for such files have -1, -2=2E=2E=2E inner suffixes=2E The complete TPC= -DS test suite runs with passes, skips and xfails, but no failures, as refl= ected by runs of $IMPALA_HOME/tests/run-tests=2Epy query_test/test_tpcds_qu= eries=2Epy =2E=2E=2E Expected result sets come from the TPC-DS kit=2E Some= TPC-DS test cases in this commit have been modified in sematically-neutral= ways so as to pass on Impala; others are marked to skip or xfail due to bu= gs=2E Tests that flap are marked to skip, with a bug ID, since they don't = reliably pass or xfail=2E The tests/query_test/test_tpcds_queries=2Epy driv= er file is authoritative for the active/skip/xfail status for each case and= a brief reason=2E The following list describes the current status as: ---= test-name deviance from TPC-DS spec changes made --- tpcds-q22a=2Etest RE= SULT MISMATCH in LSD of AVG() values Fixed AVG()s --- tpcds-q30=2Etest UNRE= COGNIZED CHARACTER MARKED XFAIL, IMPALA-5961=2E --- tpcds-q31=2Etest RESULT= MISMATCH in LSD of DECIMAL values ADDED TRUNCATE(2)s AROUND LAST 4 COLUMNS= =2E MARKED SKIP, IMPALA-5956 --- tpcds-q35a=2Etest RESULT MISMATCH MARKED X= FAIL, IMPALA-5950=2E --- tpcds-q36a=2Etest RESULT MISMATCH MARKED XFAIL, IM= PALA-4741 --- tpcds-q39=2Etest MULTIPLE RESULT SET not recognized by test f= ramework MARKED XFAIL=2E --- tpcds-q47=2Etest RESULT MISMATCH in LSD of DEC= IMAL values ADDED TRUNCATE(2) TO 8th COLUMN OF WITH TABLE, TAKE ACTUAL RESU= LT AS EXPECTED=2E --- tpcds-q49=2Etest RESULT MISMATCH in LSD of DECIMAL va= lues MARKED XFAIL, IMPALA-5945 --- tpcds-q57=2Etest RESULT MISMATCH, excess= scale in DECIMAL values FIXED, ADDED TRUNCATE(2) AROUND 6th COLUMN=2E --- = tpcds-q58=2Etest RESULT MISMATCH in DECIMAL values MARKED XFAIL=2E IMPALA-5= 946 --- tpcds-q59=2Etest RESULT MISMATCH, excess scale in DECIMAL values FI= XED, ADDED TRUNCATE(2) AROUND 4th-10th COLUMNS=2E --- tpcds-q61=2Etest RESU= LT MISMATCH in DECIMAL value FIXED=2E CAST RESULT QUOTIENT TO DECIMAL(15, 4= ), TAKE ACTUAL RESULT AS EXPECTED --- tpcds-q63=2Etest RESULT MISMATCH, exc= ess scale in DECIMAL values ADDED TRUNCATE(2) TO 3rd COLUMN --- tpcds-q64= =2Etest RESULT MISMATCH ADDED ORDER BY COLUMNS=2E --- tpcds-q66=2Etest RESU= LT MISMATCH MARKED XFAIL, IMPALA-4741 --- tpcds-q77a=2Etest RESULT MISMATCH= FIXED=2E TAKE ACTUAL RESULT AS EXPECTED --- tpcds-q78=2Etest RESULT MISMAT= CH FIXED=2E TAKE ACTUAL RESULT AS EXPECTED --- tpcds-q83=2Etest RESULT MISM= ATCH MARKED XFAIL=2E IMPALA-5945=2E --- tpcds-q85=2Etest MISSING TABLE "rea= son" MARKED XFAIL, IMPALA-5960 --- tpcds-q86a=2Etest RESULT MISMATCH FIXED= =2E TAKE ACTUAL RESULT AS EXPECTED --- tpcds-q89=2Etest RESULT MISMATCH, DE= CIMAL values flap MARKED XFAIL=2E ADDED ROUND(2) TO 8th COLUMN, TAKE ACTUAL= RESULTS AS EXPECTED, IMPALA-5956=2E --- tpcds-q90=2Etest RESULT MISMATCH M= ARKED XFAIL, IMPALA-5945=2E --- tpcds-q93=2Etest MISSING TABLE "reason" MAR= KED XFAIL, IMPALA-5960 --- tpcds-q98=2Etest RESULT MISMATCH FIXED, ADDED RO= UND() TO LAST COLUMN IMPALA-5986: Allow SET option names to contain digits= when resetting them between queries=2E Change-Id: I6e284888600a7a69d1f23f= cb7dac21cbb13b7d66 --- A testdata/workloads/tpcds/queries/tpcds-q10=2Etest = A testdata/workloads/tpcds/queries/tpcds-q10a=2Etest A testdata/workloads/t= pcds/queries/tpcds-q11=2Etest A testdata/workloads/tpcds/queries/tpcds-q12= =2Etest A testdata/workloads/tpcds/queries/tpcds-q13=2Etest A testdata/work= loads/tpcds/queries/tpcds-q14-1=2Etest A testdata/workloads/tpcds/queries/t= pcds-q14-2=2Etest A testdata/workloads/tpcds/queries/tpcds-q14a-1=2Etest A = testdata/workloads/tpcds/queries/tpcds-q14a-2=2Etest A testdata/workloads/t= pcds/queries/tpcds-q15=2Etest A testdata/workloads/tpcds/queries/tpcds-q16= =2Etest A testdata/workloads/tpcds/queries/tpcds-q17=2Etest A testdata/work= loads/tpcds/queries/tpcds-q18=2Etest A testdata/workloads/tpcds/queries/tpc= ds-q18a=2Etest A testdata/workloads/tpcds/queries/tpcds-q20=2Etest A testda= ta/workloads/tpcds/queries/tpcds-q21=2Etest A testdata/workloads/tpcds/quer= ies/tpcds-q22=2Etest A testdata/workloads/tpcds/queries/tpcds-q22a=2Etest M= testdata/workloads/tpcds/queries/tpcds-q23-1=2Etest M testdata/workloads/t= pcds/queries/tpcds-q23-2=2Etest A testdata/workloads/tpcds/queries/tpcds-q2= 4-1=2Etest A testdata/workloads/tpcds/queries/tpcds-q24-2=2Etest A testdata= /workloads/tpcds/queries/tpcds-q25=2Etest A testdata/workloads/tpcds/querie= s/tpcds-q26=2Etest M testdata/workloads/tpcds/queries/tpcds-q27a=2Etest M t= estdata/workloads/tpcds/queries/tpcds-q28=2Etest A testdata/workloads/tpcds= /queries/tpcds-q29=2Etest A testdata/workloads/tpcds/queries/tpcds-q30=2Ete= st A testdata/workloads/tpcds/queries/tpcds-q31=2Etest A testdata/workloads= /tpcds/queries/tpcds-q32=2Etest A testdata/workloads/tpcds/queries/tpcds-q3= 3=2Etest A testdata/workloads/tpcds/queries/tpcds-q35=2Etest A testdata/wor= kloads/tpcds/queries/tpcds-q35a=2Etest A testdata/workloads/tpcds/queries/t= pcds-q36=2Etest A testdata/workloads/tpcds/queries/tpcds-q36a=2Etest A test= data/workloads/tpcds/queries/tpcds-q37=2Etest A testdata/workloads/tpcds/qu= eries/tpcds-q38=2Etest A testdata/workloads/tpcds/queries/tpcds-q39-1=2Etes= t A testdata/workloads/tpcds/queries/tpcds-q39-2=2Etest A testdata/workload= s/tpcds/queries/tpcds-q40=2Etest A testdata/workloads/tpcds/queries/tpcds-q= 41=2Etest A testdata/workloads/tpcds/queries/tpcds-q44=2Etest A testdata/wo= rkloads/tpcds/queries/tpcds-q45=2Etest M testdata/workloads/tpcds/queries/t= pcds-q47=2Etest A testdata/workloads/tpcds/queries/tpcds-q48=2Etest A testd= ata/workloads/tpcds/queries/tpcds-q49=2Etest A testdata/workloads/tpcds/que= ries/tpcds-q5=2Etest A testdata/workloads/tpcds/queries/tpcds-q50=2Etest A = testdata/workloads/tpcds/queries/tpcds-q51=2Etest A testdata/workloads/tpcd= s/queries/tpcds-q51a=2Etest A testdata/workloads/tpcds/queries/tpcds-q54=2E= test A testdata/workloads/tpcds/queries/tpcds-q56=2Etest A testdata/workloa= ds/tpcds/queries/tpcds-q57=2Etest A testdata/workloads/tpcds/queries/tpcds-= q58=2Etest M testdata/workloads/tpcds/queries/tpcds-q59=2Etest A testdata/w= orkloads/tpcds/queries/tpcds-q5a=2Etest A testdata/workloads/tpcds/queries/= tpcds-q60=2Etest M testdata/workloads/tpcds/queries/tpcds-q61=2Etest A test= data/workloads/tpcds/queries/tpcds-q62=2Etest M testdata/workloads/tpcds/qu= eries/tpcds-q63=2Etest A testdata/workloads/tpcds/queries/tpcds-q64=2Etest = A testdata/workloads/tpcds/queries/tpcds-q66=2Etest A testdata/workloads/tp= cds/queries/tpcds-q67=2Etest A testdata/workloads/tpcds/queries/tpcds-q67a= =2Etest A testdata/workloads/tpcds/queries/tpcds-q69=2Etest A testdata/work= loads/tpcds/queries/tpcds-q70=2Etest A testdata/workloads/tpcds/queries/tpc= ds-q70a=2Etest A testdata/workloads/tpcds/queries/tpcds-q71=2Etest A testda= ta/workloads/tpcds/queries/tpcds-q72=2Etest A testdata/workloads/tpcds/quer= ies/tpcds-q74=2Etest A testdata/workloads/tpcds/queries/tpcds-q75=2Etest A = testdata/workloads/tpcds/queries/tpcds-q76=2Etest A testdata/workloads/tpcd= s/queries/tpcds-q77=2Etest A testdata/workloads/tpcds/queries/tpcds-q77a=2E= test A testdata/workloads/tpcds/queries/tpcds-q78=2Etest M testdata/workloa= ds/tpcds/queries/tpcds-q8=2Etest A testdata/workloads/tpcds/queries/tpcds-q= 80=2Etest A testdata/workloads/tpcds/queries/tpcds-q80a=2Etest A testdata/w= orkloads/tpcds/queries/tpcds-q81=2Etest A testdata/workloads/tpcds/queries/= tpcds-q82=2Etest A testdata/workloads/tpcds/queries/tpcds-q83=2Etest A test= data/workloads/tpcds/queries/tpcds-q84=2Etest A testdata/workloads/tpcds/qu= eries/tpcds-q85=2Etest A testdata/workloads/tpcds/queries/tpcds-q86=2Etest = A testdata/workloads/tpcds/queries/tpcds-q86a=2Etest A testdata/workloads/t= pcds/queries/tpcds-q87=2Etest M testdata/workloads/tpcds/queries/tpcds-q89= =2Etest A testdata/workloads/tpcds/queries/tpcds-q9=2Etest A testdata/workl= oads/tpcds/queries/tpcds-q90=2Etest A testdata/workloads/tpcds/queries/tpcd= s-q91=2Etest A testdata/workloads/tpcds/queries/tpcds-q92=2Etest A testdata= /workloads/tpcds/queries/tpcds-q93=2Etest A testdata/workloads/tpcds/querie= s/tpcds-q94=2Etest A testdata/workloads/tpcds/queries/tpcds-q95=2Etest A te= stdata/workloads/tpcds/queries/tpcds-q97=2Etest M testdata/workloads/tpcds/= queries/tpcds-q98=2Etest A testdata/workloads/tpcds/queries/tpcds-q99=2Etes= t M tests/query_test/test_tpcds_queries=2Epy 98 files changed, 12,748 inser= tions(+), 1,471 deletions(-) git pull ssh://gerrit=2Ecloudera=2Eorg:294= 18/Impala-ASF refs/changes/02/8102/12 -- To view, visit http://gerrit=2Ecl= oudera=2Eorg:8080/8102 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg= :8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Mes= sageType: newpatchset Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb1= 3b7d66 Gerrit-Change-Number: 8102 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Woo= d Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: David Knupp Gerrit-Reviewe= r: Matthew Mulder Gerrit-Reviewer: Michael Brown <= mikeb@cloudera=2Ecom> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa = Mokhtar Gerrit-Reviewer: Tim Wood --45Va7V6KlXE=--