Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 12DB9200D0F for ; Fri, 29 Sep 2017 18:16:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 118AD1609D1; Fri, 29 Sep 2017 16:16:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 571C81609C5 for ; Fri, 29 Sep 2017 18:16:16 +0200 (CEST) Received: (qmail 74256 invoked by uid 500); 29 Sep 2017 16:16:15 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 74244 invoked by uid 99); 29 Sep 2017 16:16:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 16:16:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C6C5C1A264A for ; Fri, 29 Sep 2017 16:16:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lW-UbJG7note for ; Fri, 29 Sep 2017 16:16:13 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 73A535F3CF for ; Fri, 29 Sep 2017 16:16:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8TGGBPC002411; Fri, 29 Sep 2017 16:16:11 GMT Message-Id: <201709291616.v8TGGBPC002411@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Fri, 29 Sep 2017 16:16:11 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: Lars Volker , Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5994=3A_Lower_case_struct-field_names=0A?= X-Gerrit-Change-Id: Iacd9714ac2301a55ee8b64f0102f6f156fb0370e X-Gerrit-Change-Number: 8169 X-Gerrit-ChangeURL: X-Gerrit-Commit: e1ace546d48d7fe877e31f0b5c387935196460c4 In-Reply-To: References: Reply-To: tmarshall@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com, marcelk@gmail.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="xxvJ9/MtFTE="; charset=UTF-8 archived-at: Fri, 29 Sep 2017 16:16:17 -0000 --xxvJ9/MtFTE= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Lars Volker, Alex Behm, I'd like you to reexamine a change=2E Pleas= e visit http://gerrit=2Ecloudera=2Eorg:8080/8169 to look at the new p= atch set (#3)=2E Change subject: IMPALA-5994: Lower case struct-field name= s =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E IMPALA-599= 4: Lower case struct-field names Impala tries to always store column names= in lower case=2E As part of a cleanup of issues related to upper case Kudu= column names, a check was added in Analyzer to enforce this=2E The check = fails when doing star expansion on a struct to select all fields in the cas= e where a table was created in Hive with upper case letters in a struct fie= ld name=2E This happens because Hive does not covert struct field names to = all lower case in HMS=2E The solution is to force StructField names to low= er case=2E Testing: - Added a test in test_nested_types=2Epy Change-Id: I= acd9714ac2301a55ee8b64f0102f6f156fb0370e --- M fe/src/main/java/org/apache/= impala/catalog/StructField=2Ejava M tests/query_test/test_nested_types=2Epy= 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit= =2Ecloudera=2Eorg:29418/Impala-ASF refs/changes/69/8169/3 -- To view, visi= t http://gerrit=2Ecloudera=2Eorg:8080/8169 To unsubscribe, visit http://ger= rit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branc= h: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iacd9714ac2301a= 55ee8b64f0102f6f156fb0370e Gerrit-Change-Number: 8169 Gerrit-PatchSet: 3 Ge= rrit-Owner: Thomas Tauber-Marshall Gerrit-Review= er: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall --xxvJ9/MtFTE=--