Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B059A200D1F for ; Fri, 29 Sep 2017 02:41:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AEA661609EC; Fri, 29 Sep 2017 00:41:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D45C31609CD for ; Fri, 29 Sep 2017 02:41:23 +0200 (CEST) Received: (qmail 94393 invoked by uid 500); 29 Sep 2017 00:41:23 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 94382 invoked by uid 99); 29 Sep 2017 00:41:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 00:41:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4652FCDFDD for ; Fri, 29 Sep 2017 00:41:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id nZTtlBgMydBo for ; Fri, 29 Sep 2017 00:41:21 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 40AB45FD1B for ; Fri, 29 Sep 2017 00:41:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8T0fJwA027520; Fri, 29 Sep 2017 00:41:19 GMT Message-Id: <201709290041.v8T0fJwA027520@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 9 Date: Fri, 29 Sep 2017 00:41:19 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5844=3A_use_a_MemPool_for_expr_result_allocations=0A?= X-Gerrit-Change-Id: I4ba5a7542ed90a49a4b5586c040b5985a7d45b61 X-Gerrit-Change-Number: 8025 X-Gerrit-ChangeURL: X-Gerrit-Commit: f98fb88af52728edc9f3f2a10c6dd05c7cfcb4b8 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 29 Sep 2017 00:41:19 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, kwho@cloudera.com, reviews@impala.incubator.apache.org, dhecht@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="9y87BEMS9ns="; charset=UTF-8 archived-at: Fri, 29 Sep 2017 00:41:24 -0000 --9y87BEMS9ns= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8025 ) Change subject: IMPALA-5844: use a MemPool for expr = result allocations =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 9: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c= /8025/9/be/src/exprs/agg-fn-evaluator=2Eh File be/src/exprs/agg-fn-evaluato= r=2Eh: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8025/9/be/src/exprs/agg-fn-= evaluator=2Eh@175 PS9, Line 175: /// This should generally be used via Sc= opedResultsPool instead of directly=2E > Yeah, we can't change the UDA inte= rface=2E But was pondering whether the eval Right, I think that changing th= e interface so that the caller could pass in a potentially different MemPoo= l to each Serialize()/Finalize() call without changing the UDA interface wo= uld be more of a mess than the current code since you'd end up having to so= mehow pass the pointers around the back of the UDA interface for every call= =2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8025 To unsub= scribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project:= Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change= -Id: I4ba5a7542ed90a49a4b5586c040b5985a7d45b61 Gerrit-Change-Number: 8025 G= errit-PatchSet: 9 Gerrit-Owner: Tim Armstrong G= errit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael = Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 29 Sep 2017 00:41:19 +0000 Gerrit-HasCom= ments: Yes --9y87BEMS9ns=--