Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CEC1C200D0B for ; Wed, 27 Sep 2017 17:05:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CD4C51609CA; Wed, 27 Sep 2017 15:05:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 203B21609BC for ; Wed, 27 Sep 2017 17:05:35 +0200 (CEST) Received: (qmail 99352 invoked by uid 500); 27 Sep 2017 15:05:35 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 99341 invoked by uid 99); 27 Sep 2017 15:05:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Sep 2017 15:05:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A2D93DE02E for ; Wed, 27 Sep 2017 15:05:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XiOOBIbBEkYL for ; Wed, 27 Sep 2017 15:05:34 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B7DD76125E for ; Wed, 27 Sep 2017 15:05:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8RF5VCt020897; Wed, 27 Sep 2017 15:05:31 GMT Message-Id: <201709271505.v8RF5VCt020897@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Wed, 27 Sep 2017 15:05:31 +0000 From: "Csaba Ringhofer (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Lars Volker X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5983=3A_Fix_crash_in_to/from_utc_timestamp=28=2210=3A00=3A00=22=2C_=27MSK=27=29=0A?= X-Gerrit-Change-Id: I592389333a16a15a680beed389e2702dfc16fe1d X-Gerrit-Change-Number: 8139 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4da24e330c7b5042780912659a3fef0cecdf3d15 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 27 Sep 2017 15:05:31 +0000 Reply-To: csringhofer@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="oDvkto0TvQc="; charset=UTF-8 archived-at: Wed, 27 Sep 2017 15:05:37 -0000 --oDvkto0TvQc= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Csaba Ringhofer has posted comments on this change=2E ( http://gerrit=2Eclo= udera=2Eorg:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_= utc_timestamp("10:00:00", 'MSK') =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E Patch Set 2: > Thanks for fixing this=2E Can you add = some tests? I have added a new check an end-to-end tests=2E -- To view, = visit http://gerrit=2Ecloudera=2Eorg:8080/8139 To unsubscribe, visit http:/= /gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-B= ranch: master Gerrit-MessageType: comment Gerrit-Change-Id: I592389333a16a1= 5a680beed389e2702dfc16fe1d Gerrit-Change-Number: 8139 Gerrit-PatchSet: 2 Ge= rrit-Owner: Csaba Ringhofer Gerrit-Reviewer: C= saba Ringhofer Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Wed, 27 Sep 2017 15:05:31 +0000 Gerr= it-HasComments: No --oDvkto0TvQc=--