Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0BD80200D12 for ; Sat, 23 Sep 2017 04:41:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0A37F1609E5; Sat, 23 Sep 2017 02:41:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 507421609D0 for ; Sat, 23 Sep 2017 04:41:37 +0200 (CEST) Received: (qmail 96816 invoked by uid 500); 23 Sep 2017 02:41:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 96804 invoked by uid 99); 23 Sep 2017 02:41:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Sep 2017 02:41:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8E0F0C58C4 for ; Sat, 23 Sep 2017 02:41:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id tL1GuVsWYwO3 for ; Sat, 23 Sep 2017 02:41:34 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E5C815FD02 for ; Sat, 23 Sep 2017 02:41:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8N2fWxI013968; Sat, 23 Sep 2017 02:41:32 GMT Message-Id: <201709230241.v8N2fWxI013968@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 8 Date: Sat, 23 Sep 2017 02:41:32 +0000 From: "Impala Public Jenkins (Code Review)" To: Zach Amsden , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4513=3A_Promote_integer_types_for_ABS=28=29=0A?= X-Gerrit-Change-Id: I86cc880e78258d5f90471bd8af4caeb4305eed77 X-Gerrit-Change-Number: 8004 X-Gerrit-ChangeURL: X-Gerrit-Commit: f53ce3b16d476214167a686ecb513c6d866105b9 In-Reply-To: References: Reply-To: zamsden@cloudera.com, impala-cr@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="9kRX9+H3RzY="; charset=UTF-8 archived-at: Sat, 23 Sep 2017 02:41:38 -0000 --9kRX9+H3RzY= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Impala Public Jenkins has submitted this change and it was merged=2E ( http= ://gerrit=2Ecloudera=2Eorg:8080/8004 ) Change subject: IMPALA-4513: Promot= e integer types for ABS() =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E IMPALA-4513: Promote integer types for ABS() The internal re= presentation of the most negative number in two's complement requires 1 mor= e bit to represent the positive version=2E This means ABS() must promote i= nteger types to the next highest width=2E Change-Id: I86cc880e78258d5f9047= 1bd8af4caeb4305eed77 Reviewed-on: http://gerrit=2Ecloudera=2Eorg:8080/8004 = Reviewed-by: Tim Armstrong Tested-by: Impala Pu= blic Jenkins --- M be/src/exprs/expr-test=2Ecc M be/src/exprs/math-function= s-ir=2Ecc M be/src/exprs/math-functions=2Eh M common/function-registry/impa= la_functions=2Epy M testdata/workloads/functional-query/queries/QueryTest/e= xprs=2Etest 5 files changed, 41 insertions(+), 13 deletions(-) Approvals: = Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verifi= ed -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8004 To unsubscr= ibe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Im= pala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id:= I86cc880e78258d5f90471bd8af4caeb4305eed77 Gerrit-Change-Number: 8004 Gerri= t-PatchSet: 8 Gerrit-Owner: Zach Amsden Gerrit-Rev= iewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewe= r: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Ge= rrit-Reviewer: Zach Amsden --9kRX9+H3RzY=--