Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 666D1200D12 for ; Sat, 23 Sep 2017 02:04:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 64E531609E5; Sat, 23 Sep 2017 00:04:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AA72A1609D0 for ; Sat, 23 Sep 2017 02:04:42 +0200 (CEST) Received: (qmail 9630 invoked by uid 500); 23 Sep 2017 00:04:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 9619 invoked by uid 99); 23 Sep 2017 00:04:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Sep 2017 00:04:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id ED27218254D for ; Sat, 23 Sep 2017 00:04:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id KpD3DCNK1QjT for ; Sat, 23 Sep 2017 00:04:40 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0E6685FD71 for ; Sat, 23 Sep 2017 00:04:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8N04dpk011982; Sat, 23 Sep 2017 00:04:39 GMT Message-Id: <201709230004.v8N04dpk011982@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 5 Date: Sat, 23 Sep 2017 00:04:39 +0000 From: "Alex Behm (Code Review)" To: Vuk Ercegovac , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1767_Adds_predicate_to_test_boolean_values_true=2C_false=2C_unknown=2E=0A?= X-Gerrit-Change-Id: I9d5fba65ef6c87dfc55a25d2c45246f74eb48c40 X-Gerrit-Change-Number: 8122 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1e44bfa370fa0fe314d4f4e0bf68d71da5a058ba In-Reply-To: References: X-Gerrit-Comment-Date: Sat, 23 Sep 2017 00:04:39 +0000 Reply-To: alex.behm@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org, vercegovac@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="UEr8NZYDWnc="; charset=UTF-8 archived-at: Sat, 23 Sep 2017 00:04:43 -0000 --UEr8NZYDWnc= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Alex Behm has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/8122 ) Change subject: IMPALA-1767 Adds predicate to test bool= ean values true, false, unknown=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E Patch Set 5: Code-Review+2 (1 comment) I'll merge= after the final simple change http://gerrit=2Ecloudera=2Eorg:8080/#/c/812= 2/5/be/src/exprs/expr-test=2Ecc File be/src/exprs/expr-test=2Ecc: http://g= errit=2Ecloudera=2Eorg:8080/#/c/8122/5/be/src/exprs/expr-test=2Ecc@2551 PS5= , Line 2551: TEST_F(ExprTest, IsBoolPredicate) { BoolTestExpr -- To vie= w, visit http://gerrit=2Ecloudera=2Eorg:8080/8122 To unsubscribe, visit htt= p://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerri= t-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5fba65ef6= c87dfc55a25d2c45246f74eb48c40 Gerrit-Change-Number: 8122 Gerrit-PatchSet: 5= Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: A= lex Behm Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sat, 23 Sep 2017 00:04:39 +0000 = Gerrit-HasComments: Yes --UEr8NZYDWnc=--