Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1FDB1200D01 for ; Fri, 22 Sep 2017 19:46:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1E4831609D0; Fri, 22 Sep 2017 17:46:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 144C61609BE for ; Fri, 22 Sep 2017 19:46:43 +0200 (CEST) Received: (qmail 37786 invoked by uid 500); 22 Sep 2017 17:46:43 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 37775 invoked by uid 99); 22 Sep 2017 17:46:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Sep 2017 17:46:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7AD041A6DB6 for ; Fri, 22 Sep 2017 17:46:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.562 X-Spam-Level: ** X-Spam-Status: No, score=2.562 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_MANYTO=0.2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 3NYqUamvF1pZ for ; Fri, 22 Sep 2017 17:46:39 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 53D1A5FBB1 for ; Fri, 22 Sep 2017 17:46:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8MHka15030096; Fri, 22 Sep 2017 17:46:36 GMT Message-Id: <201709221746.v8MHka15030096@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Fri, 22 Sep 2017 17:46:36 +0000 From: "Tim Wood (Code Review)" To: Matthew Mulder , Michael Brown , David Knupp , Alex Behm , Mostafa Mokhtar , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5376=3A_Implement_all_TPCDS_test_cases_or_alternates_for_Impala=2E=0A?= X-Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 X-Gerrit-Change-Number: 8102 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7c8391e3a8738d35e5d2f86f83214694e0060d0f In-Reply-To: References: Reply-To: twood@cloudera.com, mmulder@cloudera.com, impala-cr@cloudera.com, dknupp@cloudera.com, marcelk@gmail.com, mmokhtar@cloudera.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org, mikeb@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="LFChaUhBmW4="; charset=UTF-8 archived-at: Fri, 22 Sep 2017 17:46:45 -0000 --LFChaUhBmW4= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Matthew Mulder, Michael Brown, David Knupp, Alex Behm, Mostafa Mokhta= r, Michael Ho, I'd like you to reexamine a change=2E Please visit ht= tp://gerrit=2Ecloudera=2Eorg:8080/8102 to look at the new patch set (#2)= =2E Change subject: IMPALA-5376: Implement all TPCDS test cases or alterna= tes for Impala=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E IMPALA-5376: Implement all TPCDS test cases or alternates for Impala= =2E Main source for TPCDS query and result definitions: https://github=2Ec= om/gregrahn/tpcds-kit=2E TPC-DS v2=2E5=2E0 qualification queries from G=2E = Rahn=2E Data set constructed in mini-cluster using incubator-impala/bin/bui= ldall=2Esh -testdata=2E=2E=2E=2E Complete TPC-DS test suite runs with pass= es, skips and xfails, but no failures=2E This commit splits multi-query tes= ts in the TPC-DS suite definition into one query and result set per test fi= le, as the test framework requires=2E Names for such files have -1, -2=2E= =2E=2E inner suffixes=2E Some TPC-DS test cases in this commit have been m= odified in sematically-neutral ways so as to pass on Impala; others are mar= ked to skip or xfail due to bugs=2E Tests that flap are marked to skip, wit= h a bug ID, since they don't reliably pass or xfail=2E The tests/query_tes= t/test_tpcds_queries=2Epy driver file is authoritative for the active/skip/= xfail status for each case and a brief reason=2E The following list describ= es the current status as: --- test-name deviance from TPC-DS spec changes m= ade --- tpcds-q22a=2Etest RESULT MISMATCH in LSD of AVG() values Fixed AVG= ()s --- tpcds-q30=2Etest UNRECOGNIZED CHARACTER MARKED XFAIL, CDH-59396=2E = --- tpcds-q35a=2Etest RESULT MISMATCH MARKED XFAIL, IMPALA-5950=2E --- tpcd= s-q36a=2Etest RESULT MISMATCH MARKED XFAIL, IMPALA-4741 --- tpcds-q39=2Etes= t MULTIPLE RESULT SET not recognized by test framework MARKED XFAIL=2E --- = tpcds-q47=2Etest RESULT MISMATCH in LSD of DECIMAL values ADDED TRUNCATE(2)= TO 8th COLUMN OF WITH TABLE, TAKE ACTUAL RESULT AS EXPECTED=2E --- tpcds-q= 49=2Etest RESULT MISMATCH in LSD of DECIMAL values MARKED XFAIL, IMPALA-594= 5 --- tpcds-q57=2Etest RESULT MISMATCH, excess scale in DECIMAL values FIXE= D, ADDED TRUNCATE(2) AROUND 6th COLUMN=2E --- tpcds-q58=2Etest RESULT MISMA= TCH in DECIMAL values MARKED XFAIL=2E IMPALA-5946 --- tpcds-q59=2Etest RESU= LT MISMATCH, excess scale in DECIMAL values FIXED, ADDED TRUNCATE(2) AROUND= 4th-10th COLUMNS=2E --- tpcds-q61=2Etest RESULT MISMATCH in DECIMAL value = FIXED=2E CAST RESULT QUOTIENT TO DECIMAL(15, 4), TAKE ACTUAL RESULT AS EXPE= CTED --- tpcds-q63=2Etest RESULT MISMATCH, excess scale in DECIMAL values A= DDED TRUNCATE(2) TO 3rd COLUMN --- tpcds-q64=2Etest RESULT MISMATCH ADDED O= RDER BY COLUMNS=2E --- tpcds-q66=2Etest RESULT MISMATCH MARKED XFAIL, IMPAL= A-4741 --- tpcds-q77a=2Etest RESULT MISMATCH FIXED=2E TAKE ACTUAL RESULT AS= EXPECTED --- tpcds-q78=2Etest RESULT MISMATCH FIXED=2E TAKE ACTUAL RESULT = AS EXPECTED --- tpcds-q83=2Etest RESULT MISMATCH MARKED XFAIL=2E IMPALA-594= 5=2E --- tpcds-q85=2Etest MISSING TABLE "reason" MARKED XFAIL, CDH-59394 --= - tpcds-q86a=2Etest RESULT MISMATCH FIXED=2E TAKE ACTUAL RESULT AS EXPECTED= --- tpcds-q89=2Etest RESULT MISMATCH, DECIMAL values flap MARKED XFAIL=2E = ADDED ROUND(2) TO 8th COLUMN, TAKE ACTUAL RESULTS AS EXPECTED, IMPALA-5956= =2E --- tpcds-q90=2Etest RESULT MISMATCH MARKED XFAIL, IMPALA-5945=2E --- t= pcds-q93=2Etest MISSING TABLE "reason" MARKED XFAIL, CDH-59394 --- tpcds-q9= 8=2Etest RESULT MISMATCH FIXED, ADDED ROUND() TO LAST COLUMN Change-Id: I6= e284888600a7a69d1f23fcb7dac21cbb13b7d66 --- A testdata/workloads/tpcds/quer= ies/tpcds-q10=2Etest A testdata/workloads/tpcds/queries/tpcds-q10a=2Etest A= testdata/workloads/tpcds/queries/tpcds-q11=2Etest A testdata/workloads/tpc= ds/queries/tpcds-q12=2Etest A testdata/workloads/tpcds/queries/tpcds-q13=2E= test A testdata/workloads/tpcds/queries/tpcds-q14-1=2Etest A testdata/workl= oads/tpcds/queries/tpcds-q14-2=2Etest A testdata/workloads/tpcds/queries/tp= cds-q14a-1=2Etest A testdata/workloads/tpcds/queries/tpcds-q14a-2=2Etest A = testdata/workloads/tpcds/queries/tpcds-q15=2Etest A testdata/workloads/tpcd= s/queries/tpcds-q16=2Etest A testdata/workloads/tpcds/queries/tpcds-q17=2Et= est A testdata/workloads/tpcds/queries/tpcds-q18=2Etest A testdata/workload= s/tpcds/queries/tpcds-q18a=2Etest A testdata/workloads/tpcds/queries/tpcds-= q20=2Etest A testdata/workloads/tpcds/queries/tpcds-q21=2Etest A testdata/w= orkloads/tpcds/queries/tpcds-q22=2Etest A testdata/workloads/tpcds/queries/= tpcds-q22a=2Etest M testdata/workloads/tpcds/queries/tpcds-q23-1=2Etest M t= estdata/workloads/tpcds/queries/tpcds-q23-2=2Etest A testdata/workloads/tpc= ds/queries/tpcds-q24-1=2Etest A testdata/workloads/tpcds/queries/tpcds-q24-= 2=2Etest A testdata/workloads/tpcds/queries/tpcds-q25=2Etest A testdata/wor= kloads/tpcds/queries/tpcds-q26=2Etest M testdata/workloads/tpcds/queries/tp= cds-q27a=2Etest M testdata/workloads/tpcds/queries/tpcds-q28=2Etest A testd= ata/workloads/tpcds/queries/tpcds-q29=2Etest A testdata/workloads/tpcds/que= ries/tpcds-q30=2Etest A testdata/workloads/tpcds/queries/tpcds-q31=2Etest A= testdata/workloads/tpcds/queries/tpcds-q32=2Etest A testdata/workloads/tpc= ds/queries/tpcds-q33=2Etest A testdata/workloads/tpcds/queries/tpcds-q35=2E= test A testdata/workloads/tpcds/queries/tpcds-q35a=2Etest A testdata/worklo= ads/tpcds/queries/tpcds-q36=2Etest A testdata/workloads/tpcds/queries/tpcds= -q36a=2Etest A testdata/workloads/tpcds/queries/tpcds-q37=2Etest A testdata= /workloads/tpcds/queries/tpcds-q38=2Etest A testdata/workloads/tpcds/querie= s/tpcds-q39-1=2Etest A testdata/workloads/tpcds/queries/tpcds-q39-2=2Etest = A testdata/workloads/tpcds/queries/tpcds-q40=2Etest A testdata/workloads/tp= cds/queries/tpcds-q41=2Etest A testdata/workloads/tpcds/queries/tpcds-q44= =2Etest A testdata/workloads/tpcds/queries/tpcds-q45=2Etest M testdata/work= loads/tpcds/queries/tpcds-q47=2Etest A testdata/workloads/tpcds/queries/tpc= ds-q48=2Etest A testdata/workloads/tpcds/queries/tpcds-q49=2Etest A testdat= a/workloads/tpcds/queries/tpcds-q5=2Etest A testdata/workloads/tpcds/querie= s/tpcds-q50=2Etest A testdata/workloads/tpcds/queries/tpcds-q51=2Etest A te= stdata/workloads/tpcds/queries/tpcds-q51a=2Etest A testdata/workloads/tpcds= /queries/tpcds-q54=2Etest A testdata/workloads/tpcds/queries/tpcds-q56=2Ete= st A testdata/workloads/tpcds/queries/tpcds-q57=2Etest A testdata/workloads= /tpcds/queries/tpcds-q58=2Etest M testdata/workloads/tpcds/queries/tpcds-q5= 9=2Etest A testdata/workloads/tpcds/queries/tpcds-q5a=2Etest A testdata/wor= kloads/tpcds/queries/tpcds-q60=2Etest M testdata/workloads/tpcds/queries/tp= cds-q61=2Etest A testdata/workloads/tpcds/queries/tpcds-q62=2Etest M testda= ta/workloads/tpcds/queries/tpcds-q63=2Etest A testdata/workloads/tpcds/quer= ies/tpcds-q64=2Etest A testdata/workloads/tpcds/queries/tpcds-q66=2Etest A = testdata/workloads/tpcds/queries/tpcds-q67=2Etest A testdata/workloads/tpcd= s/queries/tpcds-q67a=2Etest A testdata/workloads/tpcds/queries/tpcds-q69=2E= test A testdata/workloads/tpcds/queries/tpcds-q70=2Etest A testdata/workloa= ds/tpcds/queries/tpcds-q70a=2Etest A testdata/workloads/tpcds/queries/tpcds= -q71=2Etest A testdata/workloads/tpcds/queries/tpcds-q72=2Etest A testdata/= workloads/tpcds/queries/tpcds-q74=2Etest A testdata/workloads/tpcds/queries= /tpcds-q75=2Etest A testdata/workloads/tpcds/queries/tpcds-q76=2Etest A tes= tdata/workloads/tpcds/queries/tpcds-q77=2Etest A testdata/workloads/tpcds/q= ueries/tpcds-q77a=2Etest A testdata/workloads/tpcds/queries/tpcds-q78=2Etes= t M testdata/workloads/tpcds/queries/tpcds-q8=2Etest A testdata/workloads/t= pcds/queries/tpcds-q80=2Etest A testdata/workloads/tpcds/queries/tpcds-q80a= =2Etest A testdata/workloads/tpcds/queries/tpcds-q81=2Etest A testdata/work= loads/tpcds/queries/tpcds-q82=2Etest A testdata/workloads/tpcds/queries/tpc= ds-q83=2Etest A testdata/workloads/tpcds/queries/tpcds-q84=2Etest A testdat= a/workloads/tpcds/queries/tpcds-q85=2Etest A testdata/workloads/tpcds/queri= es/tpcds-q86=2Etest A testdata/workloads/tpcds/queries/tpcds-q86a=2Etest A = testdata/workloads/tpcds/queries/tpcds-q87=2Etest M testdata/workloads/tpcd= s/queries/tpcds-q89=2Etest A testdata/workloads/tpcds/queries/tpcds-q9=2Ete= st A testdata/workloads/tpcds/queries/tpcds-q90=2Etest A testdata/workloads= /tpcds/queries/tpcds-q91=2Etest A testdata/workloads/tpcds/queries/tpcds-q9= 2=2Etest A testdata/workloads/tpcds/queries/tpcds-q93=2Etest A testdata/wor= kloads/tpcds/queries/tpcds-q94=2Etest A testdata/workloads/tpcds/queries/tp= cds-q95=2Etest A testdata/workloads/tpcds/queries/tpcds-q97=2Etest M testda= ta/workloads/tpcds/queries/tpcds-q98=2Etest A testdata/workloads/tpcds/quer= ies/tpcds-q99=2Etest M tests/query_test/test_tpcds_queries=2Epy 98 files ch= anged, 12,749 insertions(+), 1,471 deletions(-) git pull ssh://gerrit= =2Ecloudera=2Eorg:29418/Impala-ASF refs/changes/02/8102/2 -- To view, visi= t http://gerrit=2Ecloudera=2Eorg:8080/8102 To unsubscribe, visit http://ger= rit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branc= h: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6e284888600a7a= 69d1f23fcb7dac21cbb13b7d66 Gerrit-Change-Number: 8102 Gerrit-PatchSet: 2 Ge= rrit-Owner: Tim Wood Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer= : Michael Brown Gerrit-Reviewer: Michael Ho Gerrit-R= eviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Woo= d --LFChaUhBmW4=--