Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201709220625.v8M6PK7w025548@ip-10-146-233-104.ec2.internal>
Date: Fri, 22 Sep 2017 06:25:20 +0000
From: "Zoram Thanga (Code Review)" <gerrit@cloudera.org>
To: Zoram Thanga <zoram@cloudera.com>, Matthew Jacobs <mjacobs@apache.org>,
        impala-cr@cloudera.com, reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5599=3A_Fix_for_mis-use_of_TimestampValue=0A?=
In-Reply-To: <gerrit.1505515089000.I9b0ae06f6d94968c87a199625aa3332b26988142@gerrit.cloudera.org>
References: <gerrit.1505515089000.I9b0ae06f6d94968c87a199625aa3332b26988142@gerrit.cloudera.org>
Reply-To: zoram@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com,
        zoram@cloudera.com, reviews@impala.incubator.apache.org,
        mjacobs@apache.org, dhecht@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="ZDUw3B70Ot8="; charset=UTF-8
archived-at: Fri, 22 Sep 2017 06:25:26 -0000

--ZDUw3B70Ot8=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Matthew Jacobs, Dan Hecht, 

I'd like you to reexamine a change=2E Pl=
ease visit

    http://gerrit=2Ecloudera=2Eorg:8080/8084

to look at the ne=
w patch set (#5)=2E

Change subject: IMPALA-5599: Fix for mis-use of Timest=
ampValue
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E

IMPA=
LA-5599: Fix for mis-use of TimestampValue

The TimestampValue class is bei=
ng used for non-database purposes
in many places, such as in log messages=
=2E

This change proposes to introduce APIs to convert Unix timetamps
into =
the corresponding date-time strings=2E We provide a series of
functions for=
 different input time units, and also give the user
control over the precis=
ion of the output date-time string=2E APIs
are provided to format in UTC an=
d local time zones=2E The new APIs
can be used to replace (or instead of) T=
imestampValue::ToString()
in those places where Unix timestamps are being c=
onverted to
strings for printing=2E

The current commit implements the APIs=
 and replaces calls to
TimestampValue::ToString() in be/src/service=2E

A n=
ew unit test, time-test, has been added to the back-end tests=2E

Other use=
s of TimestampValue in be/src/service, such as to track
start and end times=
 of queries, etc=2E, will be analyzed and changed
as appropriate in a follo=
w-up commit=2E

Change-Id: I9b0ae06f6d94968c87a199625aa3332b26988142
---
M =
be/src/service/impala-server=2Ecc
M be/src/util/CMakeLists=2Etxt
A be/src/u=
til/time-test=2Ecc
M be/src/util/time=2Ecc
M be/src/util/time=2Eh
5 files c=
hanged, 284 insertions(+), 13 deletions(-)


  git pull ssh://gerrit=2Eclou=
dera=2Eorg:29418/Impala-ASF refs/changes/84/8084/5
-- 
To view, visit http:=
//gerrit=2Ecloudera=2Eorg:8080/8084
To unsubscribe, visit http://gerrit=2Ec=
loudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: mast=
er
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b0ae06f6d94968c87a19=
9625aa3332b26988142
Gerrit-Change-Number: 8084
Gerrit-PatchSet: 5
Gerrit-Ow=
ner: Zoram Thanga <zoram@cloudera=2Ecom>
Gerrit-Reviewer: Dan Hecht <dhecht=
@cloudera=2Ecom>
Gerrit-Reviewer: Matthew Jacobs <mjacobs@apache=2Eorg>
Ger=
rit-Reviewer: Zoram Thanga <zoram@cloudera=2Ecom>

--ZDUw3B70Ot8=--