Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E4A00200D08 for ; Thu, 21 Sep 2017 23:41:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E33FE1609E1; Thu, 21 Sep 2017 21:41:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3D1631609DB for ; Thu, 21 Sep 2017 23:41:36 +0200 (CEST) Received: (qmail 24312 invoked by uid 500); 21 Sep 2017 21:41:35 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 24296 invoked by uid 99); 21 Sep 2017 21:41:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Sep 2017 21:41:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 877181A62F5 for ; Thu, 21 Sep 2017 21:41:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5fbZPP34BmPm for ; Thu, 21 Sep 2017 21:41:32 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 6EC4C5FBDF for ; Thu, 21 Sep 2017 21:41:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8LLfVeA016636; Thu, 21 Sep 2017 21:41:31 GMT Message-Id: <201709212141.v8LLfVeA016636@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 8 Date: Thu, 21 Sep 2017 21:41:31 +0000 From: "Impala Public Jenkins (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5416=3A_Fix_an_impala-shell_command_recursion_bug=0A?= X-Gerrit-Change-Id: I453af2d4694d47e184031cb07ecd2af259ba20f3 X-Gerrit-Change-Number: 8063 X-Gerrit-ChangeURL: X-Gerrit-Commit: bd08ed42304b7375f5bc9c5ba6d72088cc76678a In-Reply-To: References: Reply-To: impala-cr@cloudera.com, twang@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="3qhYN1QkuGA="; charset=UTF-8 archived-at: Thu, 21 Sep 2017 21:41:37 -0000 --3qhYN1QkuGA= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Impala Public Jenkins has submitted this change and it was merged=2E ( http= ://gerrit=2Ecloudera=2Eorg:8080/8063 ) Change subject: IMPALA-5416: Fix an= impala-shell command recursion bug =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E IMPALA-5416: Fix an impala-shell command recursion b= ug Impala-shell crashes with 2 source commands on the same line and runs a= command multiple times if it shares the same line with a source command=2E= The bug is caused by a misuse of cmdqueue=2E The cmdqueue member of cmd=2E= Cmd is used to execute commands not directly from user input in an event lo= op=2E When a 'source' is run, execute_query_list() is called which also exe= cutes the commands in cmdqueue, causing them to be executed twice=2E The fi= x is for execute_query_list() to not run the commands in cmdqueue=2E For th= e non-interactive case, where the event loop won't be run, we call execute_= query_list() with cmdqueue so that the commands get run=2E A test case is a= dded to test_shell_interactive=2Epy=2E Change-Id: I453af2d4694d47e184031cb= 07ecd2af259ba20f3 Reviewed-on: http://gerrit=2Ecloudera=2Eorg:8080/8063 Rev= iewed-by: Alex Behm Tested-by: Impala Public J= enkins --- M shell/impala_shell=2Epy M tests/shell/test_shell_interactive= =2Epy 2 files changed, 10 insertions(+), 4 deletions(-) Approvals: Alex = Behm: Looks good to me, approved Impala Public Jenkins: Verified -- To = view, visit http://gerrit=2Ecloudera=2Eorg:8080/8063 To unsubscribe, visit = http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Ge= rrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I453af2d46= 94d47e184031cb07ecd2af259ba20f3 Gerrit-Change-Number: 8063 Gerrit-PatchSet:= 8 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Alex B= ehm Gerrit-Reviewer: Impala Public Jenkins Ger= rit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Thom= as Tauber-Marshall Gerrit-Reviewer: Tianyi Wang = --3qhYN1QkuGA=--