Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201709201944.v8KJir2t010844@ip-10-146-233-104.ec2.internal>
Date: Wed, 20 Sep 2017 19:44:53 +0000
From: "David Knupp (Code Review)" <gerrit@cloudera.org>
To: Tim Wood <twood@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>,
        Mostafa Mokhtar <mmokhtar@cloudera.com>,
        Michael Brown <mikeb@cloudera.com>
Reply-To: dknupp@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5376=3A_Implement_all_TPCDS_test_cases_or_alternates_for_Impala=2E=0A?=
In-Reply-To: <gerrit.1505848777000.I6e284888600a7a69d1f23fcb7dac21cbb13b7d66@gerrit.cloudera.org>
References: <gerrit.1505848777000.I6e284888600a7a69d1f23fcb7dac21cbb13b7d66@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Wed, 20 Sep 2017 19:44:58 -0000

David Knupp has posted comments on this change.

Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8102/1//COMMIT_MSG
Commit Message:

Line 11: Data set constructed in mini-cluster using incubator-impala/bin/buildall.sh -testdata....
I think this sentence is awkward. "incubator-impala" happens to be what the directory is called on your system. I suspect that most people have renamed their local directories to "Impala." A better choice would be ${IMPALA_HOME}/bin/etc...

I also think it might be helpful to reference this patch, although I'm not sure which link preferable. Yo might want to solicit opinions on that.
https://github.com/apache/incubator-impala/commit/f1558957
http://gerrit.cloudera.org:8080/6877


-- 
To view, visit http://gerrit.cloudera.org:8080/8102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-HasComments: Yes