Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E2E94200D0C for ; Wed, 20 Sep 2017 18:35:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E17EA1609E2; Wed, 20 Sep 2017 16:35:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2BA2B1609D8 for ; Wed, 20 Sep 2017 18:35:27 +0200 (CEST) Received: (qmail 38008 invoked by uid 500); 20 Sep 2017 16:35:26 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 37997 invoked by uid 99); 20 Sep 2017 16:35:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Sep 2017 16:35:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AA9F91A0F69 for ; Wed, 20 Sep 2017 16:35:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id fPF7o54Q8pTX for ; Wed, 20 Sep 2017 16:35:24 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8F8235F5B6 for ; Wed, 20 Sep 2017 16:35:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8KGZMiV000605; Wed, 20 Sep 2017 16:35:22 GMT Message-Id: <201709201635.v8KGZMiV000605@ip-10-146-233-104.ec2.internal> Date: Wed, 20 Sep 2017 16:35:22 +0000 From: "Tim Armstrong (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Lars Volker Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5425=3A_Add_test_for_validating_input_when_setting_query_options=0A?= X-Gerrit-Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7 X-Gerrit-ChangeURL: X-Gerrit-Commit: deda79f6c673b38413ae747a9040d6ee628abf52 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 20 Sep 2017 16:35:28 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7805/7/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: Line 198: auto enum_and_int = fusion::make_tuple( > Does std::make_tuple not work here? Could we avoid the use of tuples here if we changed TestEnumCaseSet to just run a single test at a time? E.g. TestEnumCaseSet(MAKE_KEYDEF(prefetchmode, TPrefetchMode, (NONE, HT_BUCKET)); TestEnumCaseSet(...); -- To view, visit http://gerrit.cloudera.org:8080/7805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes