Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 568F0200D0A for ; Wed, 20 Sep 2017 03:28:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 54D3C1609E0; Wed, 20 Sep 2017 01:28:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 990641609DD for ; Wed, 20 Sep 2017 03:28:39 +0200 (CEST) Received: (qmail 9792 invoked by uid 500); 20 Sep 2017 01:28:38 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 9781 invoked by uid 99); 20 Sep 2017 01:28:38 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Sep 2017 01:28:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 13EC2CD57D for ; Wed, 20 Sep 2017 01:28:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 0fGt-5cP5Dt3 for ; Wed, 20 Sep 2017 01:28:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A714260D24 for ; Wed, 20 Sep 2017 01:28:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8K1SWQn024945; Wed, 20 Sep 2017 01:28:32 GMT Message-Id: <201709200128.v8K1SWQn024945@ip-10-146-233-104.ec2.internal> Date: Wed, 20 Sep 2017 01:28:31 +0000 From: "Lars Volker (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: lv@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5927=3A_Fix_enable_distcc_for_zsh=0A?= X-Gerrit-Change-Id: I88284e4f68c309bb46ce4b5a842ccc576cd487ed X-Gerrit-ChangeURL: X-Gerrit-Commit: 6bf6429ccef995edd855ed928fbc906273895d3c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 20 Sep 2017 01:28:40 -0000 Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8049 to look at the new patch set (#3). Change subject: IMPALA-5927: Fix enable_distcc for zsh ...................................................................... IMPALA-5927: Fix enable_distcc for zsh enable_distcc didn't work on zsh anymore since it relies on automatic variable splitting, which only works in bash. This change moves clean-up actions for cmake files into an own bash script. This change also unifies variable quoting in clean.sh. Change-Id: I88284e4f68c309bb46ce4b5a842ccc576cd487ed --- A bin/clean-cmake.sh M bin/clean.sh M bin/distcc/distcc_env.sh 3 files changed, 49 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/8049/3 -- To view, visit http://gerrit.cloudera.org:8080/8049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I88284e4f68c309bb46ce4b5a842ccc576cd487ed Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong