Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 588B9200CF7 for ; Tue, 19 Sep 2017 23:24:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 56D3A1609DD; Tue, 19 Sep 2017 21:24:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9C2731609BF for ; Tue, 19 Sep 2017 23:24:35 +0200 (CEST) Received: (qmail 79224 invoked by uid 500); 19 Sep 2017 21:24:34 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 79203 invoked by uid 99); 19 Sep 2017 21:24:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Sep 2017 21:24:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 27C60184530 for ; Tue, 19 Sep 2017 21:24:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id r5yU-4KqEShH for ; Tue, 19 Sep 2017 21:24:33 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 3F2775F4E5 for ; Tue, 19 Sep 2017 21:24:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8JLOWvG009122; Tue, 19 Sep 2017 21:24:32 GMT Message-Id: <201709192124.v8JLOWvG009122@ip-10-146-233-104.ec2.internal> Date: Tue, 19 Sep 2017 21:24:32 +0000 From: "Tim Armstrong (Code Review)" To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5927=3A_Fix_enable_distcc_for_zsh=0A?= X-Gerrit-Change-Id: I88284e4f68c309bb46ce4b5a842ccc576cd487ed X-Gerrit-ChangeURL: X-Gerrit-Commit: cdcb3cddb3a0df6957982f8e97a0f788b8bb941b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 19 Sep 2017 21:24:36 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/8049/2//COMMIT_MSG Commit Message: Line 12: This change makes zsh temporarily emulate sh to make enable_distcc work Update http://gerrit.cloudera.org:8080/#/c/8049/2/bin/clean.sh File bin/clean.sh: Line 77: $IMPALA_HOME/bin/clean-cmake.sh nit: maybe quote "$IMPALA_HOME" for consistency Although this file already has three different forms of path :( -- To view, visit http://gerrit.cloudera.org:8080/8049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88284e4f68c309bb46ce4b5a842ccc576cd487ed Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes