Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B502C200D0F for ; Fri, 15 Sep 2017 04:52:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B38911609CE; Fri, 15 Sep 2017 02:52:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 025001609CD for ; Fri, 15 Sep 2017 04:52:07 +0200 (CEST) Received: (qmail 81122 invoked by uid 500); 15 Sep 2017 02:52:07 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 81098 invoked by uid 99); 15 Sep 2017 02:52:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Sep 2017 02:52:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 068CBCD744 for ; Fri, 15 Sep 2017 02:52:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rMQi4-v87cYv for ; Fri, 15 Sep 2017 02:52:05 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id EDDE960D9A for ; Fri, 15 Sep 2017 02:52:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8F2q30t031751; Fri, 15 Sep 2017 02:52:03 GMT Message-Id: <201709150252.v8F2q30t031751@ip-10-146-233-104.ec2.internal> Date: Fri, 15 Sep 2017 02:52:03 +0000 From: "Philip Zeyliger (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Tim Armstrong , Bharath Vissapragada Reply-To: philip@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5908=3A_Allow_SET_to_unset_modified_query_options=2E=0A?= X-Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9 X-Gerrit-ChangeURL: X-Gerrit-Commit: 336de8007b951be8b34d6826e06f86de4a90e2da In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 15 Sep 2017 02:52:08 -0000 Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8070/2/be/src/service/query-options.h File be/src/service/query-options.h: PS2, Line 127: unset > "reset the key to its default value" I think is more accurate Done http://gerrit.cloudera.org:8080/#/c/8070/2/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: PS2, Line 80: stirng > Thanks, this is helpful Done -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes