Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8F0A7200D0F for ; Fri, 15 Sep 2017 02:25:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8DABE1609CD; Fri, 15 Sep 2017 00:25:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D34421609CE for ; Fri, 15 Sep 2017 02:25:57 +0200 (CEST) Received: (qmail 41457 invoked by uid 500); 15 Sep 2017 00:25:57 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 41446 invoked by uid 99); 15 Sep 2017 00:25:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Sep 2017 00:25:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 597E6184BAB for ; Fri, 15 Sep 2017 00:25:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id jf5nmWcAibgv for ; Fri, 15 Sep 2017 00:25:55 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 84EFC5FB57 for ; Fri, 15 Sep 2017 00:25:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8F0Psb1028693; Fri, 15 Sep 2017 00:25:54 GMT Message-Id: <201709150025.v8F0Psb1028693@ip-10-146-233-104.ec2.internal> Date: Fri, 15 Sep 2017 00:25:53 +0000 From: "Tim Armstrong (Code Review)" To: Dan Hecht , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3877=3A_support_unpatched_LLVM=0A?= X-Gerrit-Change-Id: I3dfbe44ed8a1464b9b0991fd54e72b194ad6155d X-Gerrit-ChangeURL: X-Gerrit-Commit: 7177bf572b220ba57da68b14c9e779b73dc64aa5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 15 Sep 2017 00:25:58 -0000 Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7973 to look at the new patch set (#3). Change subject: IMPALA-3877: support unpatched LLVM ...................................................................... IMPALA-3877: support unpatched LLVM The p1 patch we use for LLVM avoided merging of structurally identical Struct types in unpredictable ways when linking in IR UDF modules. This avoided hitting type assertions when generating calls to IR UDfs. This implements an alternative solution, which is to bitcast the arguments when calling IR UDFs. This means we do not need to carry the patch when we upgrade LLVM. Testing: Ran core tests with unpatched LLVM 3.8, including the IR UDF test that originally required the patch to pass. Change-Id: I3dfbe44ed8a1464b9b0991fd54e72b194ad6155d --- M be/src/codegen/CMakeLists.txt M be/src/codegen/codegen-anyval.cc A be/src/codegen/codegen-util.cc A be/src/codegen/codegen-util.h M be/src/codegen/llvm-codegen.h M be/src/exprs/expr-codegen-test.cc 6 files changed, 158 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/7973/3 -- To view, visit http://gerrit.cloudera.org:8080/7973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3dfbe44ed8a1464b9b0991fd54e72b194ad6155d Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong