Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201709142111.v8ELBI1i019870@ip-10-146-233-104.ec2.internal>
Date: Thu, 14 Sep 2017 21:11:18 +0000
From: "Dan Hecht (Code Review)" <gerrit@cloudera.org>
To: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Bharath Vissapragada <bharathv@cloudera.com>,
        Vuk Ercegovac <vercegovac@cloudera.com>,
        Alex Behm <alex.behm@cloudera.com>
Reply-To: dhecht@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5538=3A_Use_explicit_catalog_versions_for_deleted_objects=0A?=
In-Reply-To: <gerrit.1503095963000.I93cb7a033dc8f0d3e0339394b36affe14523274c@gerrit.cloudera.org>
References: <gerrit.1503095963000.I93cb7a033dc8f0d3e0339394b36affe14523274c@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Thu, 14 Sep 2017 21:11:25 -0000

Dan Hecht has posted comments on this change.

Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7731/3/common/thrift/StatestoreService.thrift
File common/thrift/StatestoreService.thrift:

PS3, Line 86: deleted
> What I tried to explain in the commit msg (let me know if it still unclear)
What I meant is that we should explain in the comment here what 'value' means when 'deleted'=true. it doesn't seem intuitive what 'value' would be in that case (in most systems, "delete" operations deal only with the 'key' not the 'value').


PS3, Line 105: The from_version will always be 0 for non-delta updates
> The to_version is 0 only when there are no changes in the topic. It's value
Yeah. what I meant was we should document it in this comment, right?


-- 
To view, visit http://gerrit.cloudera.org:8080/7731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93cb7a033dc8f0d3e0339394b36affe14523274c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercegovac@cloudera.com>
Gerrit-HasComments: Yes