Return-Path: <reviews-return-20987-archive-asf-public=cust-asf.ponee.io@impala.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id A6A91200D0F
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 14 Sep 2017 20:40:14 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id A5F281609C6; Thu, 14 Sep 2017 18:40:14 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id F012B1609CD
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 14 Sep 2017 20:40:13 +0200 (CEST)
Received: (qmail 54861 invoked by uid 500); 14 Sep 2017 18:40:13 -0000
Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@impala.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@impala.incubator.apache.org>
List-Post: <mailto:reviews@impala.incubator.apache.org>
List-Id: <reviews.impala.incubator.apache.org>
Delivered-To: mailing list reviews@impala.incubator.apache.org
Received: (qmail 54806 invoked by uid 99); 14 Sep 2017 18:40:12 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Sep 2017 18:40:12 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BF50A1A6778
	for <reviews@impala.apache.org>; Thu, 14 Sep 2017 18:40:10 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.362
X-Spam-Level: 
X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31
	tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id D4mxYgDYHq0K for <reviews@impala.apache.org>;
	Thu, 14 Sep 2017 18:40:10 +0000 (UTC)
Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id DD2C05FCB9
	for <reviews@impala.incubator.apache.org>; Thu, 14 Sep 2017 18:40:09 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8EIe8ZN008937;
	Thu, 14 Sep 2017 18:40:09 GMT
Message-Id: <201709141840.v8EIe8ZN008937@ip-10-146-233-104.ec2.internal>
Date: Thu, 14 Sep 2017 18:40:08 +0000
From: "Bharath Vissapragada (Code Review)" <gerrit@cloudera.org>
To: Philip Zeyliger <philip@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Dan Hecht <dhecht@cloudera.com>, Tim Armstrong <tarmstrong@cloudera.com>
Reply-To: bharathv@cloudera.com
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5908=3A_Allow_SET_to_unset_modified_query_options=2E=0A?=
X-Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9
X-Gerrit-ChangeURL: <http://gerrit.cloudera.org:8080/8070>
X-Gerrit-Commit: 65ff3c9f485fa2da9a77ce3a31887de6a4ca2805
In-Reply-To: <gerrit.1505408250000.Ia8c383e68064f839cb5000118901dff77b4e5cb9@gerrit.cloudera.org>
References: <gerrit.1505408250000.Ia8c383e68064f839cb5000118901dff77b4e5cb9@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Thu, 14 Sep 2017 18:40:14 -0000

Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5908: Allow SET to unset modified query options.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8070/1//COMMIT_MSG
Commit Message:

Line 9: The query 'SET <option>=""' will now unset option, reverting it to
A quick question, did you consider other alternatives like "UNSET <option>" or "RESET <option>" before settling for this?  

Reason being, users might confuse this with NONE. For example,

SET COMPRESSION_CODEC="" -> COMPRESSION_CODEC=SNAPPY (default)
SET COMPRESSION_CODE=NONE-> COMPRESSION_CODEC=NONE


-- 
To view, visit http://gerrit.cloudera.org:8080/8070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes