Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D144D200CFC for ; Thu, 14 Sep 2017 00:23:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CE51E1609CB; Wed, 13 Sep 2017 22:23:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1EEC11609CA for ; Thu, 14 Sep 2017 00:23:46 +0200 (CEST) Received: (qmail 39045 invoked by uid 500); 13 Sep 2017 22:23:46 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 39024 invoked by uid 99); 13 Sep 2017 22:23:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Sep 2017 22:23:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AB0B618CAA0 for ; Wed, 13 Sep 2017 22:23:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id KYOGS8HE767n for ; Wed, 13 Sep 2017 22:23:44 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 80D225F23E for ; Wed, 13 Sep 2017 22:23:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8DMNgLq023553; Wed, 13 Sep 2017 22:23:43 GMT Message-Id: <201709132223.v8DMNgLq023553@ip-10-146-233-104.ec2.internal> Date: Wed, 13 Sep 2017 22:23:42 +0000 From: "Joe McDonnell (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: joemcdonnell@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1649_Pass_precision_to_Print_TCounterType=3A=3ADOUBLE_VALUE=0A?= X-Gerrit-Change-Id: Icc63d8a59bdf175341097df143798fb1a957d93f X-Gerrit-ChangeURL: X-Gerrit-Commit: 6e07cc0448bc699a4971ec13e3a89badb646b3b6 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 13 Sep 2017 22:23:48 -0000 Joe McDonnell has posted comments on this change. Change subject: IMPALA-1649 Pass precision to Print TCounterType::DOUBLE_VALUE ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7725/2/be/src/util/pretty-printer.h File be/src/util/pretty-printer.h: PS2, Line 142: case TUnit::DOUBLE_VALUE: { : double output = static_cast(value); : ss << std::setprecision(precision) << output << " "; I think TUnit::DOUBLE_VALUE is so similar to TUnit::UNIT that we should be looking to remove uses of DOUBLE_VALUE and allow UNIT to specify a precision. -- To view, visit http://gerrit.cloudera.org:8080/7725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc63d8a59bdf175341097df143798fb1a957d93f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Joe McDonnell Gerrit-HasComments: Yes