Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2698F200D0B for ; Wed, 13 Sep 2017 07:02:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2622E1609C8; Wed, 13 Sep 2017 05:02:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6F5C61609B4 for ; Wed, 13 Sep 2017 07:02:04 +0200 (CEST) Received: (qmail 82967 invoked by uid 500); 13 Sep 2017 05:01:53 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 82896 invoked by uid 99); 13 Sep 2017 05:01:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Sep 2017 05:01:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0DC6B1A73CA for ; Wed, 13 Sep 2017 05:01:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id s5AzOVL8XBUt for ; Wed, 13 Sep 2017 05:01:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D6A0560D2C for ; Wed, 13 Sep 2017 05:01:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8D51nhO007046; Wed, 13 Sep 2017 05:01:49 GMT Message-Id: <201709130501.v8D51nhO007046@ip-10-146-233-104.ec2.internal> Date: Wed, 13 Sep 2017 05:01:49 +0000 From: "Dimitris Tsirogiannis (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: dtsirogiannis@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5856=3A_Fix_outer_join_predicate_assignment=2E=0A?= X-Gerrit-Change-Id: I93db34d988cb66e00aa05d7dc161e0ca47042acb X-Gerrit-ChangeURL: X-Gerrit-Commit: 15958990557ac82c596df0d8c4ff6d68c68a516e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 13 Sep 2017 05:02:05 -0000 Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5856: Fix outer join predicate assignment. ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/8039/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: PS1, Line 1381: // Right-most full-outer join table ref that is equal to or to the left of the : // table ref materializing 'tids'. Trying to visualize this hurts my brain :) Not sure if it helps to understand the logic in this function. The comment in L1385 should suffice. PS1, Line 1385: this What is "this" refer to? After reading this more carefully, I think I understand what it means. I think it is better to move the comment below L1388. PS1, Line 1398: globalState_.ojClauseByConjunct.get(e.getId()); getOjRef(e)? http://gerrit.cloudera.org:8080/#/c/8039/1/testdata/workloads/functional-planner/queries/PlannerTest/outer-joins.test File testdata/workloads/functional-planner/queries/PlannerTest/outer-joins.test: PS1, Line 1020: from the On-clause of a left outer join Out of curiosity, did you check if we have the same issue if there is a left outer join followed by a full outer join? If we don't have a test like that, maybe add it for completion. Line 1028: and t1.bigint_col > 10 and t2.bigint_col > 30 To make it more interesting, add a where clause with one predicate that references t1 and t2 and one that references t3. -- To view, visit http://gerrit.cloudera.org:8080/8039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93db34d988cb66e00aa05d7dc161e0ca47042acb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: Yes