Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 081C7200D0B for ; Wed, 13 Sep 2017 03:07:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 072541609C8; Wed, 13 Sep 2017 01:07:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4C7B21609B4 for ; Wed, 13 Sep 2017 03:07:10 +0200 (CEST) Received: (qmail 59415 invoked by uid 500); 13 Sep 2017 01:07:09 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 59404 invoked by uid 99); 13 Sep 2017 01:07:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Sep 2017 01:07:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B50D9183A8F for ; Wed, 13 Sep 2017 01:07:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id n3cbk30JXI_t for ; Wed, 13 Sep 2017 01:07:08 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 52CA75FAC9 for ; Wed, 13 Sep 2017 01:07:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8D1740O002078; Wed, 13 Sep 2017 01:07:04 GMT Message-Id: <201709130107.v8D1740O002078@ip-10-146-233-104.ec2.internal> Date: Wed, 13 Sep 2017 01:07:04 +0000 From: "Tianyi Wang (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: twang@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3516=3A_Avoid_writing_to_/tmp_in_testing=0A?= X-Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4cd5ed6c4e97a8088db82add18904c6863c474ca In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 13 Sep 2017 01:07:11 -0000 Tianyi Wang has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8047/1/be/src/service/fe-support.cc File be/src/service/fe-support.cc: Line 18: > what happened here? Sorry. Didn't notice it in diff. http://gerrit.cloudera.org:8080/#/c/8047/1/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 90: private final String outDir_ = System.getenv("IMPALA_FE_TEST_LOGS_DIR") > I suggest setting this in setUp() and checking whether the env var is set. Done -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: Yes