Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201709122356.v8CNu8gX031738@ip-10-146-233-104.ec2.internal>
Date: Tue, 12 Sep 2017 23:56:08 +0000
From: "Tim Armstrong (Code Review)" <gerrit@cloudera.org>
To: Matthew Jacobs <mj@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Reply-To: tarmstrong@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5920=3A_Remove_admission_control_dependency_on_YARN_RM_jar=0A?=
In-Reply-To: <gerrit.1505173578000.I7efdd8ebea298836ca2a82c0a4ae037ac9285bcf@gerrit.cloudera.org>
References: <gerrit.1505173578000.I7efdd8ebea298836ca2a82c0a4ae037ac9285bcf@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Tue, 12 Sep 2017 23:56:13 -0000

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
......................................................................


Patch Set 2:

(3 comments)

It's a bit unfortunate that we have to pull in this much code to get it to work, but it seems like you've already pruned out the unnecessary stuff.

http://gerrit.cloudera.org:8080/#/c/8035/2//COMMIT_MSG
Commit Message:

Line 23: 'common/yarn-extras', taken from Hadoop 2.6.0.
Is the original source code that you cribbed this from available publicly somewhere? Would be handy to diff.


http://gerrit.cloudera.org:8080/#/c/8035/2/common/yarn-extras/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationConfiguration.java
File common/yarn-extras/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationConfiguration.java:

Line 19: //YARNUTIL: MODIFIED
Is there an easy way I can see the diff? If you point me to the hadoop source this was derived from I can do it myself.


http://gerrit.cloudera.org:8080/#/c/8035/2/fe/pom.xml
File fe/pom.xml:

Line 111:       <scope>system</scope>
Is systemPath necessary? We seem to be able to resolve data-source-api above without specifying this.


-- 
To view, visit http://gerrit.cloudera.org:8080/8035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7efdd8ebea298836ca2a82c0a4ae037ac9285bcf
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes