Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8B319200D0B for ; Tue, 12 Sep 2017 22:41:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 89B4F1609B4; Tue, 12 Sep 2017 20:41:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CEA961609C8 for ; Tue, 12 Sep 2017 22:41:40 +0200 (CEST) Received: (qmail 16876 invoked by uid 500); 12 Sep 2017 20:41:23 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 16674 invoked by uid 99); 12 Sep 2017 20:41:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Sep 2017 20:41:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 169BECDE4C for ; Tue, 12 Sep 2017 20:41:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 70TQ3mFUj9R9 for ; Tue, 12 Sep 2017 20:41:21 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 3C5B75FDCE for ; Tue, 12 Sep 2017 20:41:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8CKfKeU024690; Tue, 12 Sep 2017 20:41:20 GMT Message-Id: <201709122041.v8CKfKeU024690@ip-10-146-233-104.ec2.internal> Date: Tue, 12 Sep 2017 20:41:19 +0000 From: "Tianyi Wang (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: twang@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4987=3A_Fix_flaky_test_test_row_availability=2Epy=0A?= X-Gerrit-Change-Id: I96142f1868a26426cbc34aa9a0e0a56979df66c3 X-Gerrit-ChangeURL: X-Gerrit-Commit: 49b4531dc66f060b00c18c27c1a99e958eef0e15 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 12 Sep 2017 20:41:41 -0000 Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-4987: Fix flaky test test_row_availability.py ...................................................................... IMPALA-4987: Fix flaky test test_row_availability.py This patch keeps test_row_availbility from randomly failing. In this test the time interval between the 'Rows available' timeline event and the previous event in the runtime profile is measured in order to make sure that the rows become available after a specific amount of time. This measurement is not correct since the previous event is that the coordinator finished sending the query fragments to the backends, which means the execution on some backends might have already started. This patch tracks another event "Ready to start" as the beginning of the time interval instead. The coordinator begins to send the query fragments to the backends after this event so the time check should always pass. Change-Id: I96142f1868a26426cbc34aa9a0e0a56979df66c3 --- M tests/query_test/test_rows_availability.py 1 file changed, 30 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/8036/3 -- To view, visit http://gerrit.cloudera.org:8080/8036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I96142f1868a26426cbc34aa9a0e0a56979df66c3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tianyi Wang