Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 91D8D200D0E for ; Tue, 12 Sep 2017 00:08:39 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9096E1609C5; Mon, 11 Sep 2017 22:08:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D53411609C4 for ; Tue, 12 Sep 2017 00:08:38 +0200 (CEST) Received: (qmail 85437 invoked by uid 500); 11 Sep 2017 22:08:37 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 85426 invoked by uid 99); 11 Sep 2017 22:08:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Sep 2017 22:08:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E4BA6C376C for ; Mon, 11 Sep 2017 22:08:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 7-T3JZTJmEKT for ; Mon, 11 Sep 2017 22:08:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 928F15FBE2 for ; Mon, 11 Sep 2017 22:08:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v8BM8XoX031730; Mon, 11 Sep 2017 22:08:33 GMT Message-Id: <201709112208.v8BM8XoX031730@ip-10-146-233-104.ec2.internal> Date: Mon, 11 Sep 2017 22:08:33 +0000 From: "Dan Hecht (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Thomas Tauber-Marshall Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5912=3A_fix_crash_in_trunc=28=2E=2E=2E=2C_=22WW=22=29_in_release_build=0A?= X-Gerrit-Change-Id: Ic5017518188f5025daa5040ca1943581a0675726 X-Gerrit-ChangeURL: X-Gerrit-Commit: a0cd64680c75ace837c9be495c5f81f6b0a16c08 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 11 Sep 2017 22:08:39 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8015/1//COMMIT_MSG Commit Message: PS1, Line 23: Also remove other uses of references to temporary that were correct but : unnecessary given that the function returned a value and C++11 : return value optimisation should kick in. > I guess there's an element of taste to it. It definitely gets confusing. Yeah, i wasn't trying to express an opinion. just noting that it's a common pattern. -- To view, visit http://gerrit.cloudera.org:8080/8015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5017518188f5025daa5040ca1943581a0675726 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes