Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201709062059.v86KxWW3030763@ip-10-146-233-104.ec2.internal>
Date: Wed, 6 Sep 2017 20:59:32 +0000
From: "Tim Armstrong (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Jim Apple <jbapple-impala@apache.org>
Reply-To: tarmstrong@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5902=3A_add_ThreadSanitizer_build=0A?=
In-Reply-To: <gerrit.1504720762000.I22f8faeefa5e157279c5973fe28bc573b7606d50@gerrit.cloudera.org>
References: <gerrit.1504720762000.I22f8faeefa5e157279c5973fe28bc573b7606d50@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Wed, 06 Sep 2017 20:59:43 -0000

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5902: add ThreadSanitizer build
......................................................................


Patch Set 1:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/common/init.cc
File be/src/common/init.cc:

Line 142:       // The metric is refreshed whenever memory is consumed or released via a MemTracker,
A while back I changed the Process MemTracker under ASAN to use a metric. This makes it reasonable to call this.


Line 199: #ifndef THREAD_SANITIZER
> Why can't we run this with TSAN? Should the #ifndef go inside that function
There are alternative implementations of the atomic ops for TSAN. That function is not even compiled under TSAN.


http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/runtime/query-exec-mgr.cc
File be/src/runtime/query-exec-mgr.cc:

Line 115:   // tcmalloc and address sanitizer cannot be used together
> nit: "or thread"
Done


http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/util/default-path-handlers.cc
File be/src/util/default-path-handlers.cc:

Line 139:   ss << "Memory tracking is not available with address sanitizer builds.";
> nit: "or thread"
Done


http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/util/memory-metrics.cc
File be/src/util/memory-metrics.cc:

PS1, Line 86: asan
> naming?
Done


http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/util/memory-metrics.h
File be/src/util/memory-metrics.h:

Line 136: /// Alternative to TCMallocMetric if we're running under Address Sanitizer, which
> Naming?
Done


http://gerrit.cloudera.org:8080/#/c/7977/1/bin/start-impalad.sh
File bin/start-impalad.sh:

PS1, Line 104: 7
> How did you pick 7?
7 is the maximum value. I saw a few instances where the errors didn't include all info because it was aged otu of the history. https://github.com/google/sanitizers/wiki/ThreadSanitizerFlags

I guess I should use the same for the other daemons too for consistency.


http://gerrit.cloudera.org:8080/#/c/7977/1/tests/common/environ.py
File tests/common/environ.py:

Line 135:     either compiled with code coverage enabled or a sanitizer.
> except ubsan
I wasn't sure if UBSAN was just missing from this file - is it just treated as a normal debug build?


-- 
To view, visit http://gerrit.cloudera.org:8080/7977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22f8faeefa5e157279c5973fe28bc573b7606d50
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes