Return-Path: <reviews-return-20529-archive-asf-public=cust-asf.ponee.io@impala.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id DA1DB200CFD
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  6 Sep 2017 20:05:29 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id D898E1609C5; Wed,  6 Sep 2017 18:05:29 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 29B011609BB
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  6 Sep 2017 20:05:29 +0200 (CEST)
Received: (qmail 33164 invoked by uid 500); 6 Sep 2017 18:05:28 -0000
Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@impala.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@impala.incubator.apache.org>
List-Post: <mailto:reviews@impala.incubator.apache.org>
List-Id: <reviews.impala.incubator.apache.org>
Delivered-To: mailing list reviews@impala.incubator.apache.org
Received: (qmail 33145 invoked by uid 99); 6 Sep 2017 18:05:28 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Sep 2017 18:05:28 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A831D1A4CFD
	for <reviews@impala.apache.org>; Wed,  6 Sep 2017 18:05:27 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.362
X-Spam-Level: 
X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31
	tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id 0EYCCQQdJTol for <reviews@impala.apache.org>;
	Wed,  6 Sep 2017 18:05:23 +0000 (UTC)
Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 5896761036
	for <reviews@impala.incubator.apache.org>; Wed,  6 Sep 2017 18:05:22 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v86I5Jad020374;
	Wed, 6 Sep 2017 18:05:19 GMT
Message-Id: <201709061805.v86I5Jad020374@ip-10-146-233-104.ec2.internal>
Date: Wed, 6 Sep 2017 18:05:19 +0000
From: "Jim Apple (Code Review)" <gerrit@cloudera.org>
To: John Russell <jrussell@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Jim Apple <jbapple-impala@apache.org>, Greg Rahn <grahn@cloudera.com>
Reply-To: jbapple-impala@apache.org
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2107=3A_=5BDOCS=5D_Document_base64*code=28=29_functions=0A?=
X-Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
X-Gerrit-ChangeURL: <http://gerrit.cloudera.org:8080/7963>
X-Gerrit-Commit: e3067f7e188e5836db4145e9470b4919cf44b468
In-Reply-To: <gerrit.1504648464000.I5251e368ad36756c19a7b97e5ef6f232f616189b@gerrit.cloudera.org>
References: <gerrit.1504648464000.I5251e368ad36756c19a7b97e5ef6f232f616189b@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Wed, 06 Sep 2017 18:05:30 -0000

Jim Apple has posted comments on this change.

Change subject: IMPALA-2107: [DOCS] Document base64*code() functions
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7963/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

Line 802:         <codeph>MAX()</codeph>, and <codeph>MIN()</codeph> than when
Are you sure about MAX and MIN? They might preserve ordering. I don't know.


PS1, Line 808: All argument values
             :         supplied to <codeph>base64encode()</codeph> must also be a
             :         multiple of 4 bytes in length.
I don't think this is right. The example you give below, for instance, is 'hello world', which is 11 characters.

Did you mean that all arguments to base64decode must be a multiple of 4 bytes in length?


http://gerrit.cloudera.org:8080/#/c/7963/1/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

Line 88:       <dlentry id="base64decode" rev="2.9.0 IMPALA-2107">
This was fixed in 2.6.0, according to the ticket, not 2.9.0


-- 
To view, visit http://gerrit.cloudera.org:8080/7963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes