Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2BE50200CFA for ; Tue, 5 Sep 2017 19:43:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2A675160BD7; Tue, 5 Sep 2017 17:43:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 70146160BCB for ; Tue, 5 Sep 2017 19:43:26 +0200 (CEST) Received: (qmail 33696 invoked by uid 500); 5 Sep 2017 17:43:25 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 33685 invoked by uid 99); 5 Sep 2017 17:43:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Sep 2017 17:43:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4813C1A6138 for ; Tue, 5 Sep 2017 17:43:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id mhbL_fM4oM4g for ; Tue, 5 Sep 2017 17:43:19 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 51B5A5F295 for ; Tue, 5 Sep 2017 17:43:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v85HhB4u021486; Tue, 5 Sep 2017 17:43:11 GMT Message-Id: <201709051743.v85HhB4u021486@ip-10-146-233-104.ec2.internal> Date: Tue, 5 Sep 2017 17:43:11 +0000 From: "Tianyi Wang (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Tim Armstrong Reply-To: twang@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5867=3A_Fix_bugs_parsing_2-digit_year=0A?= X-Gerrit-Change-Id: Ia4f430caea88b6c33f8050a1984ee0ee32ecb0a1 X-Gerrit-ChangeURL: X-Gerrit-Commit: f71ae33c42bc44bde380be2d5948860a07d195a3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 05 Sep 2017 17:43:27 -0000 Tianyi Wang has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7910/3//COMMIT_MSG Commit Message: PS3, Line 22: 1. A date without month/day is considered invalid. Note this is : different from Hive. > why don't we do the same thing as hive? This is one of the many differences between Impala and Hive. I'm not sure how much we want to be the same with Hive and tried not to change the behaviour a lot in this bug fix. See JIRA page for the differences. -- To view, visit http://gerrit.cloudera.org:8080/7910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f430caea88b6c33f8050a1984ee0ee32ecb0a1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes