Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 272FE200CF7 for ; Tue, 5 Sep 2017 07:50:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 259A51654F4; Tue, 5 Sep 2017 05:50:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6B6C41654EF for ; Tue, 5 Sep 2017 07:50:37 +0200 (CEST) Received: (qmail 46020 invoked by uid 500); 5 Sep 2017 05:50:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 46009 invoked by uid 99); 5 Sep 2017 05:50:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Sep 2017 05:50:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CF0771A22B5 for ; Tue, 5 Sep 2017 05:50:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id FEqDzFtHBKqV for ; Tue, 5 Sep 2017 05:50:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 727B55F254 for ; Tue, 5 Sep 2017 05:50:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v855oRg0015630; Tue, 5 Sep 2017 05:50:27 GMT Message-Id: <201709050550.v855oRg0015630@ip-10-146-233-104.ec2.internal> Date: Tue, 5 Sep 2017 05:50:27 +0000 From: "Bharath Vissapragada (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Alex Behm Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_=5BPREVIEW=5D_Use_native_allocation_while_building_catalog_updates=0A?= X-Gerrit-Change-Id: I383684effa9524734ce3c6c0fb7ed37de0e15782 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8a03a140c48f23e8c0b82ec9c98ef960f3674aea In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 05 Sep 2017 05:50:38 -0000 Bharath Vissapragada has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7955/1/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: PS1, Line 113: free(buf); > This freaks me out a bit. Any documentation I've read says that you should I used free after checking that the unsafe.freeMemory() also calls the same. http://hg.openjdk.java.net/jdk8/jdk8/hotspot/file/87ee5ee27509/src/share/vm/prims/unsafe.cpp#l620 Do you think we should make a JNI call to the JVM and make it call the Unsafe#freeMemory() instead? -- To view, visit http://gerrit.cloudera.org:8080/7955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I383684effa9524734ce3c6c0fb7ed37de0e15782 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: Yes