impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vuk Ercegovac (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.
Date Tue, 19 Sep 2017 21:55:18 GMT
Vuk Ercegovac has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/8105

Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown.
......................................................................

IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

Replaces IsNullPredicate with IsNullOrBooleanPredicate in the frontend
to handle testing against null and boolean values. Similarly, the backend
expression is replaced with a corresponding expression that handles the
additional tests.

This change is a replacement candidate for gerrit.cloudera.org/8014, which
is based on front-end rewrites.

Added tests:
- Frontend: parser, analyzer, tosql
- EndToEnd query expressions

Change-Id: Ieea87e6fc8eeaf899726809d4daa4053c2bea54c
---
M be/src/codegen/impala-ir.cc
M be/src/exprs/CMakeLists.txt
M be/src/exprs/expr-test.cc
A be/src/exprs/is-null-or-bool-predicate-ir.cc
A be/src/exprs/is-null-or-bool-predicate.h
D be/src/exprs/is-null-predicate-ir.cc
D be/src/exprs/is-null-predicate.h
M be/src/exprs/scalar-expr-evaluator.cc
M be/src/exprs/scalar-expr.cc
M common/function-registry/impala_functions.py
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java
M fe/src/main/java/org/apache/impala/analysis/CaseExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
A fe/src/main/java/org/apache/impala/analysis/IsNullOrBoolPredicate.java
D fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java
M fe/src/main/java/org/apache/impala/analysis/PartitionSet.java
M fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java
M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
26 files changed, 670 insertions(+), 347 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/8105/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieea87e6fc8eeaf899726809d4daa4053c2bea54c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <vercegovac@cloudera.com>

Mime
View raw message