impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads
Date Mon, 18 Sep 2017 19:11:48 GMT
Sailesh Mukil has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/8094

Change subject: IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads
......................................................................

IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads

Kudu's ServicePool uses Kudu's Thread class to service RPC requests.
While this works well, the threads it creates aren't monitored by
Impala's ThreadMgr subsystem.

Eventually we'd like to standardise on one thread class between
projects, but for now it would be useful to reimplement ServicePool
in terms of our thread class.

The reactor threads and acceptor threads will still be Kudu threads,
but those are less likely to do substantial work, so having them
missing from monitoring isn't a big problem.

This patch just changes kudu::Thread to impala::Thread and changes
the container pointer type from scoped_refptr to unique_ptr.

Testing: Ported it on top of https://gerrit.cloudera.org/#/c/8023/
and verified that the Service pool works as expected.

Change-Id: Ibb75c91d4c754f136bcb4b51dd66e2d933b14b35
---
M be/src/kudu/rpc/service_pool.cc
M be/src/kudu/rpc/service_pool.h
2 files changed, 12 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/8094/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb75c91d4c754f136bcb4b51dd66e2d933b14b35
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message